search

IonicaBizau / web-term

:tv: A fullscreen terminal in your browser.
MIT License
168 stars 21 forks source link

terminal lines have a gap #32

Closed micimize closed 8 years ago

micimize commented 8 years ago

There's a small gap after inline-block <div/> lines that makes themes with a background change look bad:

screen shot 2016-01-04 at 21 18 55

I believe we could fix it with .terminal > div {display: flex}, but it'll also require a change to some math somewhere.

IonicaBizau commented 8 years ago

Thanks for the report!

What font do you use? When I built it, I guess I tested with Hack and monospace. :boom:

micimize commented 8 years ago

Ah, I guess I'm using "Monaco", monospace. If I change the style to monospace it looks fine. How is it even getting that font?

IonicaBizau commented 8 years ago

@michaeljosephrosenthal Maybe it would be better to use a monospaced Google font which we can be sure it will be the same. Just wondering... :smile:

micimize commented 8 years ago

https://github.com/IonicaBizau/web- Monaco comes from this style in the css, but only shows up on my browser because only macs have Monaco. Adding line-height: 1 also fixes the issue

IonicaBizau commented 8 years ago

I have the Monaco on my Ubuntu notebook.

I tested out line-height: 1 and it does fix the problem. :+1: :sparkles: If you like, make a pull request.