Fix compatibility issues with MarchingSquaresJS >= 1.3.0

IonosatMicro / promis

IonosatMicro PROMIS system

European Union Public License 1.1

0 stars 3 forks source link

Fix compatibility issues with MarchingSquaresJS >= 1.3.0 #302

Closed RaumZeit closed 5 years ago

RaumZeit commented 5 years ago

See also issue RaumZeit/MarchingSquares.js#22 and commit f6157c1ea8f078fda48c0c854fa3120c7b0f6338

RaumZeit commented 5 years ago

I don't know if I understand you correctly (I used google translate on your comment).

I'm not an expert on JavaScript/ECMAscript modules, but I think the problem is that I don't have any default exports in my library. Therefore, one needs to explicitly import all the functions required and assign them to some variable, thus

import * as MarchingSquares from MarchingSquares

gloriajjl commented 5 years ago

Yeap, thanks! That is exactly what I have written in the comment :) That was just an explanation of your fix for my colleagues.

elpiankova commented 5 years ago

Thank you!

landswellsong commented 5 years ago

@RaumZeit thank you for the PR