Fix decoding from file-like object reading too much data (#9) - Githubissues

Iotic-Labs / py-ubjson

Universal Binary JSON draft-12 serializer for Python

Apache License 2.0

42 stars 12 forks source link

Fix decoding from file-like object reading too much data (#9) #11

Closed vtermanis closed 5 years ago

vtermanis commented 5 years ago

Changes

Decoder uses buffer if seeking possible, minimal reads otherwise
Encoder/decoder buffers now unset/NULL after freeing (ext)
Added test cases for successful and failing post-decode seek calls (ext)

Testing

Versions

Python 3.6.7 64-bit (Ubuntu 18.04, macOS 10.14.4)
Python 2.7.15 64-bit (Ubuntu 18.04)
Python 3.7.3 64-bit (Windows 10)

What

C-extenions builds (with/without extra GCC flags as per setup.py where applicable)
Unit tests in pure Python & C-extension
- suite now exercises both in one run
- additional tests to cover this issue
Reference leak testing using pympler
Performance tests as per #9
Coverage tests (including for C extension)

vtermanis commented 5 years ago

Have fixed the comment typo(s).