Fix recursion test case for Python 3.12

Iotic-Labs / py-ubjson

Universal Binary JSON draft-12 serializer for Python

Apache License 2.0

42 stars 12 forks source link

Fix recursion test case for Python 3.12 #19

Open vtermanis opened 10 months ago

vtermanis commented 10 months ago

To address https://github.com/Iotic-Labs/py-ubjson/issues/18

yan12125 commented 5 months ago

Hi, is there anything to do before merging this? Maybe I can help

kapouer commented 4 months ago

This PR doesn't really fix tests for latest version of python 3.12. See https://github.com/python/cpython/issues/112282

The simplest way to fix the tests is to not call /setrecursionlimit/, just getrecursionlimit.

vtermanis commented 4 months ago

The simplest way to fix the tests is to not call /setrecursionlimit/, just getrecursionlimit.

It's not that - there's a good reason why the tests set the limit previously: The test would otherwise take too long to generate the required data or fail with a different error on earlier versions (I believe < 3.4 & 2.7.)

I'm planning to drop support for everything < 3.8 and then indeed no setting should be needed, it appears.