search

Iotic-Labs / py-ubjson

Universal Binary JSON draft-12 serializer for Python
Apache License 2.0
42 stars 12 forks source link

Sort input file list #7

Closed bmwiedemann closed 5 years ago

bmwiedemann commented 5 years ago

Sort input file list so that _ubjson.so builds in a reproducible way in spite of indeterministic filesystem readdir order and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

This PR was done while working on reproducible builds for openSUSE.

vtermanis commented 5 years ago

Thanks for the PR - that is indeed a useful change. Could you please re-raise this PR against the dev-contrib branch (as per CONTRIBUTING.md).

bmwiedemann commented 5 years ago

I changed the target of the PR to dev-contrib now.

vtermanis commented 5 years ago

Released in v0.13.0