search

Ipotrick / Daxa

Daxa is a convenient, simple and modern gpu abstraction built on vulkan
MIT License
381 stars 28 forks source link

Fixing shader group count bug #71

Closed Jaisiero closed 10 months ago

Jaisiero commented 10 months ago

-> Bug fixed and minor change to allow more group shaders in the SBT. I don't know if those should be possible to make them variable size. Daxa C interface doesn't provide any example of this. List all are fixed size I image because this is for a reason.

Jaisiero commented 10 months ago
  1. Merge with master.
  2. Fixed some bug when hit shaders overcome shader groups.
  3. Added Shader Execution Reorder (SER) support on RT pipeline.
  4. Added SBT handle offsets support.
Ipotrick commented 10 months ago

looks good to me @GabeRundlett can you take a look here?

Ipotrick commented 10 months ago

If you want them to be variable size you just pass a pointer and count to the info.

GabeRundlett commented 10 months ago

The reason that there's no variable list size is because you're able to retrieve this info, as it's stored internally. This means that it'd need to be copied in the case of a variable size, which I think is okay. We just haven't done this anywhere I think. I will see if I can add that into master for you.

GabeRundlett commented 10 months ago

Added new Span type with 73359c3df2d73aeccbe68de108d9e81f3249f888