search

IppSec / ippsec.github.io

Creative Commons Zero v1.0 Universal
140 stars 29 forks source link

Do we need jQuery? #11

Closed KMikeeU closed 4 years ago

KMikeeU commented 5 years ago

Loading jQuery takes up to about 100ms on my internet. Judging the rather minimal use of its functionality I wonder if it is really required for this project.

This page shows a couple of vanilla JS alternatives to the jQuery functions we use.

IppSec commented 5 years ago

The original implementation did not utilize JQuery, but also did a lot of other things horribly. When the code was cleaned up, it switched to JQuery for speed of development.

I wouldn't be opposed to removing that as a dependency. I'll probably take a stab at it in a few weeks if you don't beat me to it.

HexF commented 5 years ago

A complete rewrite of the code would be required for jQuery to be dropped, although we could rebuild jQuery with only the features we need.

IppSec commented 4 years ago

Closing issue with @frnkst's commit.