search

IppSec / ippsec.github.io

Creative Commons Zero v1.0 Universal
140 stars 29 forks source link

Bug in using argparse and multiple repetition of default values #28

Open StellarClown opened 2 years ago

StellarClown commented 2 years ago

Using the script I noticed that there was a bug in the commit automation script checking. The parameters had been reversed. Also, the commit flag, so to speak, the -g had wrong parameters that forced it to have an argument.

Furthermore, as explained in the issue, there is a need to change the readme, as it is incorrectly recommended to use the script. I recommend the following change: 

python yt_crawl.py -a "API_KEY_HERE" -g
StellarClown commented 2 years ago

Checking the sources, I think it is also useless to keep the yt_data.py file, as it appears to be an outdated version of this file. I also recommend updating the json file.