Ipsis / BuildersGuides

Align EVERYTHING!
GNU Lesser General Public License v3.0
4 stars 3 forks source link

Hold marker and look at ItemFrame crash #13

Closed Ipsis closed 8 years ago

Ipsis commented 8 years ago

Holding a marker and looking at an ItemFrame will cause an error due to getting the blocks state of a position that is invalid.

Reported by MrAmericanMike on the curse page.

Ipsis commented 8 years ago

The reason is that the DrawBlockHighlightEvent RayTraceResult target is not of type block. So you just need to ignore all of those events that are !BLOCK, just like the drawSelectionBox handler does.

Ipsis commented 8 years ago

Fixes the bug, but removes the block highlight from air :(