Ipsis / Woot

The alternative mob spawner/grinder system
GNU Lesser General Public License v3.0
46 stars 26 forks source link

[1.12.2][Sponge] Unable to Capture Bosses #287

Open Mohron opened 6 years ago

Mohron commented 6 years ago

I've gone through the Guidebook and I can't find any info on capturing the Ender Dragon. Punching the dragon with the shard does not work for me like it does with other mobs. Would you be willing to address this and any other special cases that might exist in the Guidebook?

Also if you can just tell me how for the meantime I'll tell my users :D

Ipsis commented 6 years ago

It should be just the same. Hit it with the ender shard to program and then kill the dragon to get shard to glow. I tend to test by cheating programmed shards in so it is possible there is an error with the dragon.

Mohron commented 6 years ago

Ya I've not been able to successfully punch the dragon.

Ipsis commented 6 years ago

I'll test that in my development environment and see if there is something special about the dragon.

Mohron commented 6 years ago

Just tested this in SP. Seems to work fine. Reporting to SpongeForge and will link here FYI.

Mohron commented 6 years ago

https://github.com/SpongePowered/SpongeForge/issues/1912

Mohron commented 6 years ago

Verified the problem also affects the wither so I expect all bosses are affected when using SF.

Ipsis commented 6 years ago

It is strange that it is only bosses as the interaction code is the same. https://github.com/Ipsis/Woot/blob/1_12/src/main/java/ipsis/woot/item/ItemEnderShard.java#L57

Unless there are intercepting the hitEntity method on EntityBoss.(?) Hopefully it is something they can fix in Sponge, or something I can update in my code to allow it to work with Sponge.

Wissi commented 6 years ago

Hi, awesome work, great Mod, lag saver. But we can confirm it is still unusable for bosses even with latest versions of Forge and Sponge and Woot. Using: Forge (1.12.2 - 14.23.4.2705), SpongeForge (1.12.2-2705-7.1.0-BETA-3401) and Woot (1.12.2-1.4.2). Would there be anything on your side that can be done to fix the issue (as you stated: " ... I can update in my code to allow it to work with Sponge."). I'll report to Sponge as well, Thank you so much for all your great work.

Ipsis commented 6 years ago

Unfortunately there is nothing I can add that would help. My offer of updating the code was very much if SpongeForge had any suggestions for me that could make it compatible. However from reading their updates it looks like there is nothing I can do.

I was under the impression that the changes for both this bug and the looting bug had been added and merged into Sponge in May. But from your comments it looks like either the fix isn't in the most recent release, or it is broken again. :(

LemADEC commented 5 years ago

As of spongeforge-1.12.2-2768-7.1.6-RC3565 and woot-1.12.2-1.4.9, only Ender dragon can't be programmed. Other bosses works fine, including Wither, Evoker, Elder guardian, Thaumcraft Eldritch construct, Nex Ghast mother and Twilight Forest hydra.

I suggest to add a recipe to craft the shard from 3 Ender dragon eggs. It's a bit more expensive since you loose the eggs, but that shouldn't be hard to get back from your Woot setup right after.

Ipsis commented 5 years ago

@LemADEC Thanks for that information. I'll see about adding a recipe behind a config option to create the Ender Dragon shard - disabled by default of course.

LemADEC commented 5 years ago

Sponge just fixed the ender dragon, I haven't had time to test it yet.