search

Ipstenu / varnish-http-purge

Proxy Cache Purge
Apache License 2.0
46 stars 47 forks source link

Multiple varnish IPs, logging of varnish server response to file can be enabled with new defined WP_LOGGING #4

Closed olipayne closed 9 years ago

olipayne commented 10 years ago

Also removed some random whitespaces throughout

Ipstenu commented 10 years ago

Why logging? Varnish already logs all this itself, so I'm iffy about adding in logging to any of this.

olipayne commented 10 years ago

We had issues seeing what the actual response from the Varnish server was 'per request'. Logging is disabled by default also.

Ipstenu commented 10 years ago

I'm going to have to think about that.

Right now, I don't plan to support multiple Varnish IPs simply because I have no way to test the code myself. I have a serious issue and worry about adding in code that I don't use myself, as it puts me in a major bind if there are issues with an upgrade that I missed because I CAN'T test it.

olipayne commented 10 years ago

Sure no problem.

Regarding the multiple Varnish IPs, I can safely confirm that if it works for one, it will work for as many Varnish instances you set up for that site. We have this code on our production setup with 2 Varnish instances per site as part of our very high availability architecture.

I'm happy to help maintain this part of the code, I think the plugin is a great script :). It'd be a shame to have to fork and not help upstream.

Let me know if you have any queries regarding our setup.

olipayne commented 10 years ago

Any thoughts on this? I'd hate to have to break our plugin from yours just to support multiple varnish instances. Am I missing something which might mean having multiple instances would affect the stability of the script?

Ipstenu commented 10 years ago

It's the same problem it's always been. It's really hard for me to want to put myself up for supporting a major feature I just don't use. It puts me in a bad spot if things break :/ I mean, lets say it doesn't work in one situation for whatever reason. Telling people "Yes, but it's unsupported" is terrible. And I really have a major thing about NOT doing that to folks.

olipayne commented 10 years ago

Sure I can understand your concern, however it's a simple foreach loop for every instance, if it works for one surely it'll work for more?

Ipstenu commented 9 years ago

Maybe later. Right now I don't have a good way to support it, so I'm not going to add in code I can't easily support/debug/test.

While I appreciate the fork and the effort, I have a personal rule where I just don't do that.