search

Ipstenu / varnish-http-purge

Proxy Cache Purge
Apache License 2.0
46 stars 47 forks source link

Multiple IP functionality not working. #89

Closed Muhammad-Zaka closed 3 years ago

Muhammad-Zaka commented 3 years ago

We have multiple varnish backend servers and using the plugin to send purge request to all of the varnish servers. The issue is when i add 1 ip it works fawlessly but when added multiple IP's with the convention suggested it stops sending request to any backend.

Ipstenu commented 3 years ago

Thanks for letting me know. I'll dig into this and see if I can reproduce the issue... You're separting with a comma, right?

Muhammad-Zaka commented 3 years ago

Yes, I am separating the servers with comma. It works just fine when i pass one IP.

Muhammad-Zaka commented 3 years ago

The text field automatically adds a space after the comma.

Ipstenu commented 3 years ago

Okay I think I know why. I made a 5.0.1 branch - https://github.com/Ipstenu/varnish-http-purge/tree/REL_5.0.1 - if you want to test it.

Muhammad-Zaka commented 3 years ago

Tested the branch 5.0.1. This time only the 1st IP is receiving purge request. The other IP's don't get any request. Attaching the screenshot of the plugin settings and varnish log on cache clear.

Screenshot_3

Screenshot_4

Ipstenu commented 3 years ago

The text field automatically adds a space after the comma.

Fyi that should be fine.

I'm going to see if I can figure out why it's not looping!

Muhammad-Zaka commented 3 years ago

The latest changes seems to have fixed the issue. I tested the site now its sending purge request to every IP.

working

Ipstenu commented 3 years ago

WHEW! Okay, I'll get that rollin for everyone this week.

Muhammad-Zaka commented 3 years ago

Sounds good. That would be great.

Muhammad-Zaka commented 3 years ago

Thanks for the fix :)