Closed ANaaim closed 8 months ago
tests/test_export_c3d.py
line 34 at r2 (raw file):
I forgot the method def export() -> None but actually saves the file.
For me the following function do not belongs to the class : get_points_ezc3d, add_point_from_dictionary ==> these two function might be use for other instance in the code. However add_technical_marker and add_natural_coortinate are linked to a
I would not call it InverseKinematicsExporter as we do not need to do a inverse kinematics to use it. ?? C3DModelExporter ??
bionc/utils/export_c3d_from_bionc_model.py
line 69 at r2 (raw file):
could store this in a variable
I do not understand
tests/test_export_c3d.py
line 34 at r2 (raw file):
For me the following function do not belongs to the class : get_points_ezc3d, add_point_from_dictionary ==> these two function might be use for other instance in the code. However add_technical_marker and add_natural_coortinate are linked to a I would not call it InverseKinematicsExporter as we do not need to do a inverse kinematics to use it. ?? C3DModelExporter ??
Script rename Done
tests/test_export_c3d.py
line 34 at r2 (raw file):
Script rename Done
New class has been done but i did not remove the transfered code from the original function
Code Climate has analyzed commit d7426f02 and detected 0 issues on this pull request.
View more on Code Climate.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.61%. Comparing base (
ce64f52
) to head (d7426f0
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
black . -l120
This change is