Ipuch / bioNC

Natural Coordinates with python for biomechanics
MIT License
11 stars 4 forks source link

[RTR] export data to c3d #111

Closed ANaaim closed 8 months ago

ANaaim commented 1 year ago

This change is Reviewable

ANaaim commented 12 months ago

tests/test_export_c3d.py line 34 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
I forgot the method def export() -> None but actually saves the file.

For me the following function do not belongs to the class : get_points_ezc3d, add_point_from_dictionary ==> these two function might be use for other instance in the code. However add_technical_marker and add_natural_coortinate are linked to a

I would not call it InverseKinematicsExporter as we do not need to do a inverse kinematics to use it. ?? C3DModelExporter ??

ANaaim commented 12 months ago

bionc/utils/export_c3d_from_bionc_model.py line 69 at r2 (raw file):

Previously, Ipuch (Pierre Puchaud) wrote…
could store this in a variable

I do not understand

ANaaim commented 12 months ago

tests/test_export_c3d.py line 34 at r2 (raw file):

Previously, ANaaim (Alexandre Naaim) wrote…
For me the following function do not belongs to the class : get_points_ezc3d, add_point_from_dictionary ==> these two function might be use for other instance in the code. However add_technical_marker and add_natural_coortinate are linked to a I would not call it InverseKinematicsExporter as we do not need to do a inverse kinematics to use it. ?? C3DModelExporter ??

Script rename Done

ANaaim commented 12 months ago

tests/test_export_c3d.py line 34 at r2 (raw file):

Previously, ANaaim (Alexandre Naaim) wrote…
Script rename Done

New class has been done but i did not remove the transfered code from the original function

codeclimate[bot] commented 9 months ago

Code Climate has analyzed commit d7426f02 and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.61%. Comparing base (ce64f52) to head (d7426f0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #111 +/- ## ========================================== + Coverage 83.36% 83.61% +0.24% ========================================== Files 91 93 +2 Lines 5862 5949 +87 ========================================== + Hits 4887 4974 +87 Misses 975 975 ``` | [Flag](https://app.codecov.io/gh/Ipuch/bioNC/pull/111/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Ipuch/bioNC/pull/111/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud) | `83.61% <100.00%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.