search

Ipuch / bioNC

Natural Coordinates with python for biomechanics
MIT License
11 stars 4 forks source link

NaturalSegmentMarkers implemented with Facade Pattern - more to come #122

Closed Ipuch closed 11 months ago

Ipuch commented 11 months ago

This change is Reviewable

codeclimate[bot] commented 11 months ago

Code Climate has analyzed commit 147a2e48 and detected 0 issues on this pull request.

View more on Code Climate.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (c0849a4) 82.08% compared to head (147a2e4) 82.41%. Report is 3 commits behind head on main.

Files Patch % Lines
bionc/bionc_casadi/natural_segment.py 97.67% 1 Missing :warning:
bionc/bionc_casadi/natural_segment_markers.py 96.29% 1 Missing :warning:
bionc/bionc_numpy/natural_segment.py 97.67% 1 Missing :warning:
bionc/bionc_numpy/natural_segment_markers.py 96.15% 1 Missing :warning:
bionc/protocols/natural_segment.py 90.90% 1 Missing :warning:
bionc/protocols/natural_segment_markers.py 97.05% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #122 +/- ## ========================================== + Coverage 82.08% 82.41% +0.32% ========================================== Files 75 78 +3 Lines 5544 5624 +80 ========================================== + Hits 4551 4635 +84 + Misses 993 989 -4 ``` | [Flag](https://app.codecov.io/gh/Ipuch/bioNC/pull/122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Ipuch/bioNC/pull/122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud) | `82.41% <96.73%> (+0.32%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.