search

Ipuch / bioNC

Natural Coordinates with python for biomechanics
MIT License
11 stars 4 forks source link

refactor(process marker) #141

Closed Ipuch closed 7 months ago

Ipuch commented 7 months ago

done

This change is Reviewable

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 97.48744% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 83.98%. Comparing base (a7cba88) to head (9d9825f). Report is 1 commits behind head on main.

Files Patch % Lines
bionc/bionc_casadi/biomechanical_model_markers.py 40.00% 3 Missing :warning:
bionc/utils/markers_check_import.py 83.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #141 +/- ## ========================================== + Coverage 83.67% 83.98% +0.31% ========================================== Files 93 96 +3 Lines 5984 6119 +135 ========================================== + Hits 5007 5139 +132 - Misses 977 980 +3 ``` | [Flag](https://app.codecov.io/gh/Ipuch/bioNC/pull/141/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Ipuch/bioNC/pull/141/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud) | `83.98% <97.48%> (+0.31%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pierre+Puchaud#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ipuch commented 7 months ago

@aaiaueil Let me know if the new attributes in ik.sol helps you, I still need to implement some tests and we are good I believe. I detailed everything in doc strings for the format of the output 3d, 2d confidence, and overall confidence !

I got some knots in heads to unpack some functions, but tests are intact, meaning I was doing it right :)

codeclimate[bot] commented 7 months ago

Code Climate has analyzed commit 9d9825f6 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.