Open Muhammad0602 opened 1 year ago
Hi @Muhammad0602,
Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!
[ ] There are some cards that are missing. Mainly frontend cards. Where is the card for adding the main page, the details page, the delete item page, and the mobile implementation? Where are the Redux cards? Kindly go here and be sure to add cards for all the project requirements according to your team's size.
[ ] At the time of this review, these are the pointings:
Muhammad0602 31 mrkamin 29 Iqbal-Elham 25 AyomipoMajek 32.5
However, according to the project requirements:
Your pointings are too wide spread.
Kindly, ensure nobody in the team has 5 more points than anyone. The hard limit difference is 5 points.
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hello @Meltrust, I think all the cards are already there. I will try to take more screenshots so that they are all seen.
Hi @Muhammad0602,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! π
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!πππ
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
We are a group of 4.
We have completed our kanban board and here is the link board