Iqbal-Elham / Ruby-capstone

In this project, we created a console app that will help us to keep a record of different types of things you own: books, music albums, and games. Built it with Ruby, and PostgreSQL
0 stars 1 forks source link

Team Members #33

Open Iqbal-Elham opened 1 year ago

Iqbal-Elham commented 1 year ago

In this issue I want to mention that we are 3 teammates working on this project.

The team members are the following:

  1. @Iqbal-Elham (Team1)
  2. @Cabraham1 (Team2)
  3. @simplegoose (Team3)

    Here is the link of the project Link

GzimAsani commented 1 year ago

Hi @Iqbal-Elham , @Cabraham1 and @simplegoose ,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not have the project link included on the description image

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

prolajumokeoni commented 1 year ago

Hi @Team Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ Each card has a descriptive title and number of points

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

prolajumokeoni commented 1 year ago

Hi @Iqbal-Elham, @simplegoose and @Cabraham1

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

✔️ Each card has a descriptive title and number of points

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

KanzaTahreem commented 1 year ago

Approved 🥳

Hi @Iqbal-Elham, @simplegoose &@Cabraham1 🙋‍♀️

Great work implementing the changes suggested by the previous reviewer 💪 Your project is COMPLETE! You can proceed with your project now! 🚀 Congratulations!

Highlights 🎯

There are some excellent points that you have made perfectly. Keep up the great work! 👏

Optional suggestions ❕

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

N/A

Cheers and Happy coding!👏👨‍💻💻

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.