search

IraSoro / peri

The period tracker app
https://irasoro.github.io/peri/
34 stars 28 forks source link

add German transalations #296

Closed whirlxd closed 3 weeks ago

whirlxd commented 1 month ago

added trans for german

whirlxd commented 1 month ago

added this for hacktoberfest

IraSoro commented 1 month ago

Hello, @whirlxd! Thanks for contributing to the project!

It looks like your PR didn't pass the auto checks. If it's not difficult, please fix what is described in sections 8, 9, 10, 11 in CONTRIBUTING.md. Or I can do it myself.

I will also write some comments from the review below.

whirlxd commented 1 month ago

It seems it's not prettier formatted, i dont use prettier could you do that

imblowfish commented 1 month ago

Hello @whirlxd we already have prettier installed as package in our repo

You can run

npm run fmt

commit changes and push them to this PR

whirlxd commented 1 month ago

hey sorry i got busy , it should be formatted now

IraSoro commented 1 month ago

Hello, @whirlxd!

If it's not difficult, please fix what is described in sections 8, 9 in CONTRIBUTING.md. Or I can do it myself.

I also wrote some comments on the code review. Please fix them.

IraSoro commented 3 weeks ago

Hello, @whirlxd! I hope you're doing well. I noticed that the German translation still has some points we discussed. If you don't have time, you can just answer my questions related to translation directly in the PR and I'll make the necessary corrections myself. If something is unclear, we'll be happy to explain!

Thank you!

whirlxd commented 3 weeks ago

Yo actually i got really busy and forgot about this. I would appreciate if you could make those changes and merge though And once again really sorry

IraSoro commented 3 weeks ago

Yo actually i got really busy and forgot about this. I would appreciate if you could make those changes and merge though And once again really sorry

@whirlxd, thanks for answering! I'll make the changes myself, but could you please answer the translation questions directly in the PR?

  1. How would you correctly translate the different forms of the word day in German? For example, in English, we have: (0) Days, (1) Day, (2-inf) Days. What are the German forms for these counts?
  2. What would be the correct translation for the phrase "Current cycle day"?
  3. How do you say '{{count}}-th day' in German? For example, in English, we say '1st day', '2nd day', '3rd day', etc. What are the corresponding forms in German for these ordinal numbers?
whirlxd commented 3 weeks ago

1 - tag , rahe, tag 2-aktueller zyklustag 3- erster tag ( 1st day), zweiter tag ( 2) and so on just add an er at the end

IraSoro commented 3 weeks ago

@whirlxd, thanks for helping with the translation into German! And congratulations on your first contribution to the Peri project!

whirlxd commented 3 weeks ago

glad to have helped