search

IraSoro / peri

The period tracker app
https://irasoro.github.io/peri/
34 stars 28 forks source link

Hacktoberfest : Added Hinglish #298

Closed IntegerAlex closed 1 month ago

IntegerAlex commented 1 month ago

Made fixes for auto-checks

IraSoro commented 1 month ago

Hello, @IntegerAlex and @akshatkot. Everything looks good!

I'd like to ask one question. Will this display be correct? {E7B7397E-8F90-4785-94F5-B64DF557236B}

I asked chatGPT about the translation. It wrote me the following answer: {BF9A4241-C257-482F-A31A-21F9FB079A64}

Does the display not contradict the rules of the language?

IraSoro commented 1 month ago

@IntegerAlex and @akshatkot, I have made a few changes to the PR:

  1. Added language to fallbackLng as described in the CONTRIBUTING.md file in section 7
  2. I renamed the language from hi to hg in the hg.ts file because the name hg is used everywhere
  3. I also changed the locale for dates from hi to enUS because I thought it would be better in this case if the dates were displayed in English instead of Hindi.

Please write to me if you think I'm wrong.

IntegerAlex commented 1 month ago

@IntegerAlex and @akshatkot, I have made a few changes to the PR: Please write to me if you think I'm wrong.

You are right

IntegerAlex commented 1 month ago

Hello, @IntegerAlex and @akshatkot. Everything looks good!

I'd like to ask one question. Will this display be correct? {E7B7397E-8F90-4785-94F5-B64DF557236B}

I asked chatGPT about the translation. It wrote me the following answer: {BF9A4241-C257-482F-A31A-21F9FB079A64}

Does the display not contradict the rules of the language? No, its same. I verified with a med student.

IntegerAlex commented 1 month ago

If there are any changes i will maintain the translation, Don't worry

IraSoro commented 1 month ago

If there are any changes i will maintain the translation, Don't worry

Everything is fine, I just fixed merge conflicts. Thank you

IraSoro commented 1 month ago

@IntegerAlex and @akshatkot Congratulations on your first contribution to peri, thank you!