search

IraSoro / peri

The period tracker app
https://irasoro.github.io/peri/
34 stars 28 forks source link

Persian translations added #321

Closed arashveysi3 closed 4 days ago

arashveysi3 commented 5 days ago

Added Persian translations fully according to Contriibution.MD instructions. plus I updated Readme.MD (Persian included in supported languages) open to future contributions and thanks for your great application. 💯 Hope it helps!

imblowfish commented 5 days ago

Hello @arashveysi3. Thank you for your contribution

I have a question. Am I right that Persian alphabet has right-to-left direction and right text alignment?

If yes, I have a request to you. Could you please run peri locally on your laptop and show us the problems with current UI which should be fixed according to right-to-left alphabet?

Of course in case if you are a native speaker and this is will not be difficult for you

You just need to exexute npm start and attach screenshot in this PR with your comments

To mark problems in the app you can use any image editor. I can recommend https://excalidraw.com as example

arashveysi3 commented 4 days ago

Hey @imblowfish Thanks for reviewing my PR. Yes, you are right in it supposed to be RTL instead of LTR. Good news is with a little of your guide I can fix it!

the problem exists in all of the pages but as an example I took a screenshot of the main page as you suggested to me, I used https://excalidraw.com and what a great app!

https://excalidraw.com/#room=cc4fb9147c008706c73e,GJ9evYHPhNV-zwVIkDJDiw

imblowfish commented 4 days ago

Hey @imblowfish Thanks for reviewing my PR. Yes, you are right in it supposed to be RTL instead of LTR. Good news is with a little of your guide I can fix it!

the problem exists in all of the pages but as an example I took a screenshot of the main page as you suggested to me, I used https://excalidraw.com and what a great app!

https://excalidraw.com/#room=cc4fb9147c008706c73e,GJ9evYHPhNV-zwVIkDJDiw

Thank you!

We'll create additional ticket for rtl interface support. Until this, could you please move Persian language to the Beta languages? We'll return it back later

And we could probably need your help. Can we tag you to check the fixes in the future?

arashveysi3 commented 4 days ago

Hey @imblowfish Thanks for reviewing my PR. Yes, you are right in it supposed to be RTL instead of LTR. Good news is with a little of your guide I can fix it! the problem exists in all of the pages but as an example I took a screenshot of the main page as you suggested to me, I used https://excalidraw.com and what a great app! https://excalidraw.com/#room=cc4fb9147c008706c73e,GJ9evYHPhNV-zwVIkDJDiw

Thank you!

We'll create additional ticket for rtl interface support. Until this, could you please move Persian language to the Beta languages? We'll return it back later

And we could probably need your help. Can we tag you to check the fixes in the future?

Yes why not! Persian language moved to Beta language section for now. let's say mission accomplished! I'm open to any further contributions on this project happily. meanwhile I am fluent in Turkish too. and It's a LTR language so I will start to translate app to Turkish too.

imblowfish commented 4 days ago

@IraSoro review plz

IraSoro commented 4 days ago

@arashveysi3, thank you for your interest in the project and for the work you've done! Congratulations on your first contribution to Peri!