search

IrcDirk / Carbonite-Classic

Carbonite + Modules for WoW Classic
https://www.curseforge.com/wow/addons/carbonite-classic
GNU General Public License v3.0
51 stars 23 forks source link

Carbonite wotlk classic problems with fps and quest log #224

Closed chaliniak closed 2 years ago

chaliniak commented 2 years ago

Basically when i got mine carbonite quest log my fps get shredded to pieces, the game is barely playable, and quest log does not want to merge with each other the only one i got working is not from addon, while the ui log is carbonite and not working image

artscout commented 2 years ago

I'm sorry but why send us screenshot of working blizzard quest log? Send us Carbonite quest log screenshot with problem clearly visible, otherwise it's hard to even begin investigation of what could be wrong.

GhineaNicolaeFlorin commented 2 years ago

Having similar issues with the FPS when Quest module is enabled. Opening the map will tank my fps to ~7. Unfortunately I do not know what logs/screenshot I could give to better understand this issue

artscout commented 2 years ago

Working on it, investigating issue. Already found some issues with quest log merging, that I'll fix soon enough. Investigating FPS dtop (I still can't reproduce it, can you send me screenshot of Carbonite quest log with "Show Quest ID" option enabled for Quest module?)

MaxShineOn commented 2 years ago

The FPS drop happens when engaging in combat mostly. Hovering mouse on target and clicking etc.

IrcDirk commented 2 years ago

I dont see any problems with FPS, took 10 quest, fighting, completing quest and still FPS is good and steady... But im using only Carbonite + Modules.

So first of all what u need to do is to test the game with ONLY Carbonite + Modules enabled, all other addons DISABLED. It might be other addon that does the FPS drop when used with Carbonite.

GhineaNicolaeFlorin commented 2 years ago

Video with fps drops that I am getting, check the mouse position on the map: https://streamable.com/a44f8c FPS drops even when hovering over NPCs, related or not to active quests that I have. It might also be a hardware issue, no I am not running this on a potato but even so these fps drops are massive. As soon as I disable only the quests module the game runs fine.

IrcDirk commented 2 years ago

@GhineaNicolaeFlorin Cant reproduce. As i wrote before... Please check with ONLY Carbonite + Modules enabled, all other Addons DISABLED.

It might be other addon that does the FPS drop when used with Carbonite Quest module.

MaxShineOn commented 2 years ago

I just tested, seems to be getting the lag drop when Questie is enabled alonside Carbonite. The lag mostly seems to occur while in combat/hovering over the mob you're attacking.

MaxShineOn commented 2 years ago

Re-testing, I can also reproduce it while the Carbonite Quest module is loaded and it has finished loading the 8275 quests according to the system message. After that, mobs and herb nodes will trigger the lag, even without any other addons running (just Maps, Notes, and Quest).

IrcDirk commented 2 years ago

Im testing on PTR and on there i got zero FPS problems... I doesn't have WoW subscription to check it on Retail Classic Pre-Wotlk. Seems it might be Blizzard issue... but cant test it...

Any donations are welcome.

nochio23 commented 2 years ago

Same issues, kills my FPS when having the quest component loaded. Mousing over literally anything in the game makes the game lag. Not a hardware issue.

IrcDirk commented 2 years ago

Is there a difference after recent WoW WOTLK Classic update (3.4.0.45435)?

GhineaNicolaeFlorin commented 2 years ago

For me the issue is still there after the update.

IrcDirk commented 2 years ago

Can someone with those problem send me compressed WTF folder?

artscout commented 2 years ago

It's probably some settings. I couldn't reproduce issue at all on live Prepatch, tried different settings (graphics settings, minimap settings like docker minimap and such). Need exact settings to see if it could be reproduced.

BetaVirus commented 2 years ago

I just loaded the game with no Mods and just carbonite and it lagged so hard it caused my Computer to become unresponsive for several minutes. Again only when the quest module is enabled.

How is it that Git does not support 7zip?! WTF.zip

MaxShineOn commented 2 years ago

Tossed you a wow sub and some Starbucks, good luck!

IrcDirk commented 2 years ago

I just loaded the game with no Mods and just carbonite and it lagged so hard it caused my Computer to become unresponsive for several minutes. Again only when the quest module is enabled.

How is it that Git does not support 7zip?! WTF.zip

Tested with your settings an all seems fine :( No fps drop.

IrcDirk commented 2 years ago

@BetaVirus Can u do me a favour and rename WTF folder to WTF2, then start WOW Classic WOTLK and test FPS on all new setting. Load only Carbonite + Modules and let me know if there is still FPS issue on your side.

After that test u can just delete WTF folder and rename WTF2 to WTF and all your settings will be back :)

BetaVirus commented 2 years ago

I am on a different computer now having the same issues. I will try the test you wanted later today.

IrcDirk commented 2 years ago

@BetaVirus On both computers u played on Classic TBC also?

nochio23 commented 2 years ago

@BetaVirus Can u do me a favour and rename WTF folder to WTF2, then start WOW Classic WOTLK and test FPS on all new setting. Load only Carbonite + Modules and let me know if there is still FPS issue on your side.

After that test u can just delete WTF folder and rename WTF2 to WTF and all your settings will be back :)

After renaming WTF to WTF2 the lag stopped for me

Edit: Scratch that, now it lags just when mousing over enemies or objectives on the map instead of lagging every time I tough anything.

artscout commented 2 years ago

NxQuest.zip Ok could you try to download this file, unpack it and placeinto Interface/Addons/Carbonite.Quests folder overwriting current file. Just a hunch to check over. See if this helps with mouseover

chaliniak commented 2 years ago

I'm sorry but why send us screenshot of working blizzard quest log? Send us Carbonite quest log screenshot with problem clearly visible, otherwise it's hard to even begin investigation of what could be wrong.

Sorry, i just wasnt on my pc for two days and was unable to response. The prolblem lies in screenshot carbonite doesnt want to open it's quest log, only wow qlog works, to addition that beatiful qlog list on right side of screen is unresponsive and doesn't want to list my tracked quests, I've seen on other forums repair tip to limit loaded quests in carbonite to +5/-5lvls from your own, but i can't find option to this. Fps drops ONLY when quest module is active, i've tested it with and without other addons

artscout commented 2 years ago

@chaliniak you too could try file I posted one post above.

chaliniak commented 2 years ago

WTFs from wow clasic in zip not rar.zip okay, so i've tried new Nx.Quests file, i've tried with and without other addons and i'm linking my WTFs folders numbered and named. Only thing i can think of next is that old WoW could use limited amount of RAM and even stronger pc's couldn't hande the fps drops (mainly in dala in northrend) and response to that was some kind of file from 3rd "company" that was unblocking the limit on wow, it wasn't made by the Blizzard but they've said that it works and i've used that "file" or program or whatever that was and my dala problems with fps drops were gone, maybe the problem is in RAM consumption by quest module?

artscout commented 2 years ago

Ok try this. When in game open carbonite settings, select quests on the left side. you'll see four tabs, last tab is database settings. There you'll see level loading limiter, try to set it up for you character

chaliniak commented 2 years ago

image there's no quest module here

artscout commented 2 years ago

Wait a moment. And you had Carbonite.Quests enabled when you took this screenshot with you having lags with mouseover?

chaliniak commented 2 years ago

yes xD

artscout commented 2 years ago

carbonite_options

You should have this when Quests module is enabled.

chaliniak commented 2 years ago

but i dont have it :V that's the problem probably with not working quest log properly too

artscout commented 2 years ago

Ok let me ask another question: open file Interface/Addons/Carbonite/Carbonite.toc, copy everything there and paste here please.

chaliniak commented 2 years ago

Interface: 30400

Title: Carbonite Maps - Classic @project-version@

Version: @project-version@

Author: No one

Notes: Released Under GPL

DefaultState: Enabled

LoadOnDemand: 0

SavedVariables: CarbData

SavedVariablesPerCharacter: CarbMigr

X-WoWI-ID: 12965

Libs\libs.xml Locales\Locales.xml Carbonite.lua NxUI.lua NxOptions.lua NxCom.lua NxHUD.lua Data\data.xml NxMapData.lua NxMap.lua NxMapGuide.lua NxTravel.lua Carbonite.xml

artscout commented 2 years ago

ok another thing to try. right after logging in game with character type this in chat: /console ScriptErrors 1 after that /reload to see if there are any errors

chaliniak commented 2 years ago

Message: Interface\AddOns\Carbonite\NxUI.lua:4567: attempt to perform arithmetic on local 'pos' (a nil value) Time: Sat Sep 3 22:16:52 2022 Count: 1 Stack: Interface\AddOns\Carbonite\NxUI.lua:4567: attempt to perform arithmetic on local 'pos' (a nil value) [string "@Interface\AddOns\Carbonite\NxUI.lua"]:4567: in function SetSlider' [string "@Interface\AddOns\Carbonite.Quests\NxQuest.lua"]:8746: in function?' [string "@Interface\AddOns\Carbonite.Quests\NxQuest.lua"]:2764: in function Init' [string "@Interface\AddOns\Carbonite.Quests\NxQuest.lua"]:2127: in functionfunc' [string "@Interface\AddOns\Carbonite\Libs\AceTimer-3.0\AceTimer-3.0.lua"]:57: in function <...\AddOns\Carbonite\Libs\AceTimer-3.0\AceTimer-3.0.lua:50>

Locals: self =

{ SliderMax = 25 User =
{ } Id = 0 Text = "Max Visible In List" Func = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:8651 Step = 1 Menu =
{ } Table =
{ } SliderMin = 1 Slider = true VarName = "NXWVisMax" ShowState = 1 } pos = nil min = 1 max = 25 step = 1 varName = "NXWVisMax" (temporary) = defined =[C]:-1 (temporary) = 1 (temporary) = 25 (temporary) = "attempt to perform arithmetic on local 'pos' (a nil value)"

Message: Interface\AddOns\Carbonite.Quests\NxQuest.lua:5423: attempt to index field 'TTIgnore' (a nil value) Time: Sat Sep 3 22:17:11 2022 Count: 2 Stack: Interface\AddOns\Carbonite.Quests\NxQuest.lua:5423: attempt to index field 'TTIgnore' (a nil value) [string "@Interface\AddOns\Carbonite.Quests\NxQuest.lua"]:5423: in function TooltipProcess2' [string "@Interface\AddOns\Carbonite.Quests\NxQuest.lua"]:5371: in functionTooltipProcess' [string "@Interface\AddOns\Carbonite\Carbonite.lua"]:974: in function `?' [string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:119: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:119>

[string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:29: in function <...sic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25> [string "@Interface\AddOns\AtlasLootClassic\Libs\CallbackHandler-1.0\CallbackHandler-1.0.lua"]:64: in function `Fire' [string "@Interface\AddOns\Carbonite\Libs\AceEvent-3.0\AceEvent-3.0.lua"]:120: in function <...\AddOns\Carbonite\Libs\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:

Message: Interface\AddOns\Carbonite.Quests\NxQuest.lua:5423: attempt to index field 'TTIgnore' (a nil value) Time: Sat Sep 3 22:17:13 2022 Count: 15 Stack: Interface\AddOns\Carbonite.Quests\NxQuest.lua:5423: attempt to index field 'TTIgnore' (a nil value) [string "@Interface\AddOns\Carbonite.Quests\NxQuest.lua"]:5423: in function TooltipProcess2' [string "@Interface\AddOns\Carbonite.Quests\NxQuest.lua"]:5371: in functionTooltipProcess' [string "@Interface\AddOns\Carbonite\Carbonite.lua"]:1314: in function `NXOnUpdate'

Locals: self =

{ IconTracking =
{ } UnpackCategory = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:10573 DailyTypes =
{ } IsTargeted = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:10339 Menu_OnTrack = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:3260 GetQuestReward = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:3314 DecodeComRcv = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:11208 MsgNotInDB = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:5273 Watch =
{ } PartyStartSend = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:11470 SortQuests = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4348 NullQuest = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:11618 CheckQuestSE = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:3198 GetFromPlyr = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:5087 Custom =
{ } TooltipProcess2 = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:5382 IdToCurQ =
{ } PerColors =
{ } GetClosestObjectivePos = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:10852 RecordQuestsLog = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:3500 ExtractTitle = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4324 CalcCNumMax = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4132 UnpackObjective = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:10610 GetQuestObjectiveInfo = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4290 ClearCaptured = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:5107 TooltipProcess = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:5358 SelectBlizz = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:3368 UnpackNext = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:10564 ShowUIPanel = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:5860 CapturePlyrData =
{ } GetObjectiveType = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:10623 PartyUpdateTimer = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:11463 MapChanged = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4024 OnParty_members_changed = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:11304 TrackedAchievements =
{ } UpdateQuestDetails = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:8312 DailyIds =
{ } CalcDesc = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4272 QLocColors =
{ } CalcPreviousDone = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4175 AccessAllQuests = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:3448 IconOnMouseDown = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:8257 OnProfileChanged = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:2157 WatchAtLogin = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4918 CreateLink = defined @Interface\AddOns\Carbonite.Quests\NxQuest.lua:4316 L

there are 3 errors right after logging

chaliniak commented 2 years ago

image this one goes up in count like crazy while mouseovering and causing a lot of fps drops

GhineaNicolaeFlorin commented 2 years ago

Can confirm that I also do not have the quests tab in settings when quest module is enabled.

artscout commented 2 years ago

Stack: Interface\AddOns\Carbonite.Quests\NxQuest.lua:5423: attempt to index field 'TTIgnore' (a nil value)

This can be ingnored, because it caused by earlier mistake. @GhineaNicolaeFlorin can you do the same thing (/console ScriptErrors 1 and /reload) to see that you have the same mistake: Message: Interface\AddOns\Carbonite\NxUI.lua:4567: attempt to perform arithmetic on local 'pos' (a nil value)

artscout commented 2 years ago

@IrcDirk they have new file so file positions are skewed. It's a Nx.Quest:GetQuestOpts() returning nil somehow.

artscout commented 2 years ago

NxQuest.zip Can you try again with this file (same as before, unpack, replace in interface/addons/Carbonite.Quests)?

chaliniak commented 2 years ago

nothing has changed

artscout commented 2 years ago

NxQuest.zip This one. Forgot to add one thing to check.

chaliniak commented 2 years ago

image we have some action, it actually works rn xD

artscout commented 2 years ago

Oh ok. What about lags?

chaliniak commented 2 years ago

Right now works like a dream even without limiting loaded quests, i'm not getting fps drops on mouseovering anything, quest log has merged together, quest tracking list is working properly, i don't have any more Lua errors with /console ScriptErrors 1 opened

artscout commented 2 years ago

Ok thank you for being damn good test partner :) I will create pull request with fix and we will push it soon.

chaliniak commented 2 years ago

Ok thank you for being damn good test partner :) I will create pull request with fix and we will push it soon.

Nice, thanks for ALL the help i had <3 luv ya, and luv Carbonite :p btw it'd be probably faster to reply and work on it with a discord chat XD

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.