search

IreneKnapp / direct-sqlite

MIT License
35 stars 54 forks source link

More ghc coverage #57

Closed tolysz closed 9 years ago

tolysz commented 9 years ago

E. adds support for ghc-7.4.2 and extend .travis.yml test more compilers

I noticed it testing mine ;) https://travis-ci.org/tolysz/sqlite-simple-typed/jobs/46552050

nurpax commented 9 years ago

squashed it into a single commit myself, committed in https://github.com/IreneKnapp/direct-sqlite/commit/b78a6d788cba422d5e761ba4355b0e701127296d

thanks!

tolysz commented 9 years ago

I am still learning my 'git-fu', any tips how to squash PR after you make them welcome :)

nurpax commented 9 years ago

"git rebase -i" is pretty good for squashing commits.

if you have already made a PR and want to update it, you can locally git rebase -i to squash your commits and "git push -f" (force push) your changes to your fork. This will update your PR.

tolysz commented 9 years ago

I will try next time... but most likely for some other project

nurpax commented 9 years ago

@tolysz BTW big thanks for doing this. It was really cool to see that direct-sqlite builds on all of GHC 7.4.2, 7.6.3, 7.8.4, 7.10.1 and head.