Irev-Dev / MRI-Volume-Slice

Tools for view MRI Volumes in the browser
6 stars 7 forks source link

added parameter support for url #38

Closed warcops closed 6 years ago

warcops commented 6 years ago

Github issue: #37

Changes proposed in this PR:

warcops commented 6 years ago

the tests failed for you because of me using arrow function instead of the conventional one. I agree with the fallback approach. Have pushed changes. Would request your review. Thanks.

Irev-Dev commented 6 years ago

Sorry I feel like I'm waisting your time, I have netlify set up to build deploy previews for pull requests, so we can view yours at https://deploy-preview-38--mrislice.netlify.com/ (with error Unhandled promise rejection TypeError: "NetworkError when attempting to fetch resource.") But it doesn't work, and when I put a link to a data set it doesn't work either. https://deploy-preview-38--mrislice.netlify.com/?https://openneuro.org/crn/datasets/ds001545/snapshots/1.0.0/files/sub-01:anat:sub-01_T1w.json (with error Unhandled promise rejection incorrect header check) 😢 Thanks for the effort.