Irev-Dev / Round-Anything

A set of OpenSCAD utilities for adding radii and fillets, that embodies a robust approach to developing OpenSCAD parts.
https://kurthutten.com/blog/round-anything-a-pragmatic-approach-to-openscad-design
MIT License
504 stars 47 forks source link

Rename sum function #48

Closed nfedyashev closed 1 year ago

nfedyashev commented 1 year ago

This name is rather generic and has a high chance of conflicting with other libraries(e.g. BOSL2) or user-defined functions.

This issue was found while I was working on a project which requires the use of both popular libraries - Round-Anything & BOSL2.

WARNING polyround.scad:689 undefined operation (number + vector)
WARNING polyround.scad:689 undefined operation (number + vector)
WARNING math.scad:663 undefined operation(undefined / number)     <-- this is from BOSL2
ERROR vectors.scad:211 Asserting 'is_vector(v)' failed: Invalid vector      <-- this is from BOSL2

This change fixed the issue for me locally.

There aren't any other function names/signatures conflicts between these 2 libraries.

I believe this is a safe update because this function is not present in public API and is only used internally