search

Irev-Dev / cadhub

We're out to raise awareness and put CodeCAD on the map. The success of CadHub can be measured by the amount it promotes the use of CodeCAD within the mechanical/manufacturing industry and the strength the CadHub community.
https://cadhub.xyz
GNU General Public License v3.0
319 stars 60 forks source link

CadHub Customizer #461

Closed Irev-Dev closed 3 years ago

Irev-Dev commented 3 years ago

Start of implementation of the CadHub customizer

follows https://github.com/Irev-Dev/cadhub/discussions/437

The idea is there is a consistent customizer on Cadhub that will work with multiple integrations.

So far this implements sting number and boolean for JSCAD, (and should work with OpenSCAD but that work is ongoing see: https://github.com/openscad/openscad/issues/3801)

It would be good to get select and groups working before we release the JSCAD integration, but I'm okay if that's added later.

hrgdavor commented 3 years ago

step is now respected. :)

one minor issue though, step is not respected while dragging ... that is irellevant now, but it may be relevant when/if u implement live update of params option.

Irev-Dev commented 3 years ago

step is now respected. :)

one minor issue though, step is not respected while dragging ... that is irellevant now, but it may be relevant when/if u implement live update of params option.

I'm not sure the steps should be enforced while the input is being actively dragged, to me it's disrespecting the user by interrupting them to change the input, rather that waiting until they are done to fix the input to match the steps.

I regards to live, I've been having trouble with it. You can see my attempt here https://github.com/Irev-Dev/cadhub/pull/new/kurt/live-customizer-attempt but something's not right, it doesn't always update when it should.

Irev-Dev commented 3 years ago

0cc335e is a rebase on main before merging.