search

Irev-Dev / cadhub

We're out to raise awareness and put CodeCAD on the map. The success of CadHub can be measured by the amount it promotes the use of CodeCAD within the mechanical/manufacturing industry and the strength the CadHub community.
https://cadhub.xyz
GNU General Public License v3.0
319 stars 60 forks source link

Show empty `KeyValue`'s if editing #526

Closed franknoirot closed 3 years ago

franknoirot commented 3 years ago

Begins #525, although more gaps in the profile validation have been found.

@Irev-Dev one interesting issue I ran into with the Bio Markdown editor is that when I tried to set my bio to nothing it still kept around an invisible newline character (value was \\n in Prisma Studio), so the bio always appeared after editing once, even after trying to delete it.

I suppose this is a vanishingly rare case though, where someone took the time to write a profile at one point but now definitely wants no bio, right? 🤷🏻‍♂️

franknoirot commented 3 years ago

We can also revert this to a Draft if you want more lines of code in this PR and to address the other validation issues I noted in #525 alongside.

Irev-Dev commented 3 years ago

Live now