Irev-Dev / cadhub

We're out to raise awareness and put CodeCAD on the map. The success of CadHub can be measured by the amount it promotes the use of CodeCAD within the mechanical/manufacturing industry and the strength the CadHub community.
https://cadhub.xyz
GNU General Public License v3.0
319 stars 60 forks source link

Parameter customizations made through the Viewer are not included in downloaded STL file #606

Open franknoirot opened 2 years ago

franknoirot commented 2 years ago

Expected Behavior

When customizing the available parameters in the Viewer pane, especially the one available on a project's details page, I would expect those customized values to take effect on the downloaded file. However, you can only ever receive the file with the parameters described in the code.

Steps to reproduce

  1. Visit https://cadhub.xyz/u/franknoirot/silverware-drawer-divider.
  2. Adjust the silverware_sections to 4 from the default 3.
  3. Click Download.

The display of the model should upgrade to the STL view which is rad, but notice that the tray only has 3 sections.

Additional notes

RagingRoosevelt commented 2 years ago

I ran into this issue on my own file. Just a data point that it isn't happening just for you.

drf5n commented 2 years ago

I note that parameter customizations reset whenever I shrink/close the parameter window. Maybe the "reload each camera move?" code is starting things from scratch when you switch windows.