You should probably setup luacheck and take its advice and try to clear out all warnings.
In particular, you should find ways to minimize the proliferation of globals, such as the data global that's used to pass mod_storage between files within citadel_core.
Generally each mod should only expose one global, with the same name as the mod's name, containing the mod's public API.
To pass data between different files within a mod without exposing things outside of the mod, there are methods to keep things strictly locally-scoped such as passing variables in and return values out with loadfile/dofile.
You should probably adopt code format standards and use an automatic formatter, preferably one that is available standalone and doesn't require a specific editor. I ended up making my own at https://gitlab.com/Warr1024/luatools but there are probably others that are good.
Consistency makes it easier to read the code, and easier for other contributors with different habits to still produce code that complies.
Having everything automatically formatted minimizes the instance of whitespace-only changes in source control that make it harder to find true changes, so it's best to adopt these measures as early as possible.
Consider setting up a git pre-commit hook to gate commits on passing linting and format checks, and try to encourage contributors to do so as well.
You should probably setup luacheck and take its advice and try to clear out all warnings.
In particular, you should find ways to minimize the proliferation of globals, such as the
dataglobal that's used to pass mod_storage between files within citadel_core.You should probably adopt code format standards and use an automatic formatter, preferably one that is available standalone and doesn't require a specific editor. I ended up making my own at https://gitlab.com/Warr1024/luatools but there are probably others that are good.
Consider setting up a git pre-commit hook to gate commits on passing linting and format checks, and try to encourage contributors to do so as well.