Closed cgreim closed 8 years ago
We'll use this ticket to create a new list of small fixes for the updated, bootstrap 4 version of the home page etc.
cat notes Home Page
About Pages
(Devin recently did a big update to units, want to showcase that we have options K-12)
savannah's nitpicky visual notes
text-decoration: none
action-img
to anything I didn't want to have a border-bottom
on hover (I realize this can be a little tedious because it's altering default behavior, but I think it looks so much better...but I'm open to change it back!)What a good time to check these off? After committing to a branch or after merging the branch to bootstrap4
?
Edit: I'm checking them off as I make commits to: https://github.com/Iridescent-CM/curiosity-machine/pull/568 so I can keep track :dancer:
New set of boxes to check, from amy and mariana's feedback:
So one note – changed menu order to Challenges / Mentors / About Us / Log In. I think this makes more sense because Challenges is the most important, and you're moving from "in platform" --> "informational" as you go
I agree, Savannah!
On Mon, Sep 28, 2015 at 2:56 PM, Savannah Million notifications@github.com wrote:
So one note – changed menu order to Challenges / Mentors / About Us / Log In. I think this makes more sense because Challenges is the most important, and you're moving from "in platform" --> "informational" as you go
— Reply to this email directly or view it on GitHub https://github.com/Iridescent-CM/curiosity-machine/issues/543#issuecomment-143885043 .
Mariana Rutigliano _Community Engagement Director Iridescent_Curiosity Machine http://curiositymachine.org |website http://www.iridescentlearning.org/ *| watch us https://www.youtube.com/watch?v=94JY-Zs1r2U* _Follow Us: [image: Facebook] http://www.facebook.com/pages/Iridescent-ONR/125009044180713 [image: Google Calendar] http://https//www.google.com/calendar/hosted/iridescentlearning.org/embed?src=heo0pf217oq2lsn9m3v8srflt4@group.calendar.google.com&ctz=America/New_York&gsessionid=97qwa0WMWfNkyFx_zDfFvQ [image: YouTube] http://www.youtube.com/user/tarachk [image: WordPress]_
more follow up, now that much of this is in staging:
Background image on mobile is a blur (in Chrome and Safari) -- maybe this is ok? need to decide what to do about it
This seems like a product of many mobile browsers not handling background-attachment: fixed; background-size: cover;
very well. I found some workarounds when the background image is applied to the page body, but not when it's applied to an element.
It seems the affected browsers scale the background image up to be the full size of the page, not just the viewport, meaning you get a super-zoomed in chunk of the full image visible. Reducing the image size will improve page load time but actually just make that super zoomed in chunk very pixelated as well, compounding the problem.
Not sure what a good solution would be yet, seems sort of like a catch-22.
@stenington can we set up a media query and serve a smaller image just to mobile devices?
if neither of those works, should we think about whether we're ok with the blurred image background, or should switch to something else for mobile (like a solid color, more like the panels further down the page)?
On Fri, Oct 2, 2015 at 1:34 PM, Savannah Million notifications@github.com wrote:
@stenington https://github.com/stenington can we set up a media query and serve a smaller image just to mobile devices?
— Reply to this email directly or view it on GitHub https://github.com/Iridescent-CM/curiosity-machine/issues/543#issuecomment-145117905 .
@savannahmillion We can do that, but that's what will result in the pixelated-ness in affected browsers. They'll stretch that smaller image to be full page height so only a tiny, highly pixelated bit will be visible.
Doing something just for mobile isn't easy, and totally changing the background might be jarring on desktop if someone chooses to make their window narrow. Although there are certainly plenty of sites that change a lot at narrow window sizes, so maybe that's just a reality that we'd have to accept?
For now let's try making the background image scroll at the same breakpoint where we switch to the mobile header, and see if that works better.
these fixes are all implemented!
starting a ticket to make a checklist of polish things for the new home page / about pages: