Closed stenington closed 4 years ago
Carry over from last iteration:
We were talking in our team time about discrepancies in judge count, and I noticed a difference between the Participants page and Judges page in the admin. I realized that the Judges page doesn't default to the current season, but the Participants page does. I don't know if that's the ultimate source of confusion about judge counts, but just noting it here for now.
And for submission location, it looks like users have their location individually recorded, and then teams have a location recorded separately from the users. A submission's location I think would be equivalent to the team's location, and it looks like the team's location will be copied from the user creating or updating the team.
So @rsgonzal in your example of a user in Brazil but a submission in California, it's probable that the team was created by a user in California, and then subsequently that user updated their location to be Brazil. I think that's a viable path to ending up with a data scenario like that. I wouldn't expect it to happen in production, but who knows.
And finally, noting that I looked into a submission on staging that seemed to have two official scores, one 0/60 one 60/60, but the average was being calculated as 60 points. Looking in the console, both scores thought themselves to be official, submission.quarterfinals_official_scores
was only returning one of the two. So either there is a discrepancy in how officiality is determined in different spots, or maybe a commit hook wasn't properly triggered at some point.
We were talking in our team time about discrepancies in judge count, and I noticed a difference between the Participants page and Judges page in the admin. I realized that the Judges page doesn't default to the current season, but the Participants page does. I don't know if that's the ultimate source of confusion about judge counts, but just noting it here for now.
I think this makes sense. Searching in judges --> 2020, still onboarding 1,197 searching in participants --> 2020, still onboarding 1,197
I think these numbers are inflated because of users with mentor profiles. If i go to judges and select that they don't have a mentor profile and still onboarding, i get 239. I think this is more accurate since users who have a mentor profile can't get to the judge dashboard right now.
So @rsgonzal in your example of a user in Brazil but a submission in California, it's probable that the team was created by a user in California, and then subsequently that user updated their location to be Brazil. I think that's a viable path to ending up with a data scenario like that. I wouldn't expect it to happen in production, but who knows.
Thanks for looking into this! Makes sense. I tried it in staging and it doesn't update my team's location when i change mine. BUT i can change my team's primary location as the user. Also don't think this will happen in production!
Deleted scores, certificates, and RPEs on staging. 🚫 💯 📜 🏫 🙅
Thanks for updating, @shaunxp20 ! so i did notice this screen is still counting those scores maybe? It's interesting that it doesn't count ones that we delete through the admin
Thanks for updating, @shaunxp20 ! so i did notice this screen is still counting those scores maybe? It's interesting that it doesn't count ones that we delete through the admin
Doh! It looks like those columns didn't get updated/triggered. I updated them manually, I think it's okay now, check it out when you have a moment. 😃
Here are the commands I ran:
TeamSubmission.update_all(submission_scores_count: nil, quarterfinals_average_score: 0.00, average_unofficial_score: 0.00, complete_semifinals_submission_scores_count: 0, complete_quarterfinals_submission_scores_count: 0, semifinals_average_score: 0.00, complete_semifinals_official_submission_scores_count: 0, complete_quarterfinals_official_submission_scores_count: 0, pending_semifinals_submission_scores_count: 0, pending_quarterfinals_submission_scores_count: 0, pending_semifinals_official_submission_scores_count: 0, pending_quarterfinals_official_submission_scores_count: 0, quarterfinals_score_range: 0, semifinals_score_range: 0)
JudgeProfile.update_all(quarterfinals_scores_count: 0, semifinals_scores_count: 0)
See https://docs.google.com/spreadsheets/d/1Mx3DlCT62cr_MZAl4C10FiWzaXxIIh4tszubmAMW18c/edit#gid=1850689656