Iridescent-CM / technovation-app

The team submission platform for the Technovation Challenge
https://technovationchallenge.org
GNU General Public License v3.0
7 stars 4 forks source link

Rebrand student page to accept or decline a mentor request #3602

Closed dboyer closed 2 years ago

dboyer commented 2 years ago

When a mentor requests to join a team, the team receives an email with a button to "Review this Request." Clicking that button takes the user to a page where they can see basic details for the mentor and accept or decline the request (/student/join_requests/....) That page currently needs rebranding as the layout is not user friendly and the approve request button is only visible upon hover.

Review Mentor Request

We'll need to find a mockup for this.

dboyer commented 2 years ago

The page where a student accepts or declines an invite to a team is very similar in content. We can follow this layout.

Screen Shot 2022-09-02 at 11 03 27 AM
shaun-technovation commented 2 years ago

This one is on QA.

A couple of notes:

dboyer commented 2 years ago

Tested on QA and confirmed that responding to a mentor invite is working as expected. I agree that the page to view an already approved/declined request is okay. I don't think it's worth updating now considering other tasks that we have.

@shaunxp20 Where is the pending student join request that you rebranded? I'm looking at /student/team_member_invites/ (the page where a student responds to an invite to join a team) and it looks like it did previously. Is there a different page I should be reviewing?

Screen Shot 2022-09-28 at 1 38 37 PM
shaun-technovation commented 2 years ago

@shaunxp20 Where is the pending student join request that you rebranded? I'm looking at /student/team_member_invites/ (the page where a student responds to an invite to join a team) and it looks like it did previously. Is there a different page I should be reviewing?

Screen Shot 2022-09-28 at 1 38 37 PM

Yes, it's a different page, it's kinda confusing. The image above is for an invite, I updated the join request pages, which is where a student or mentor requests to join a team, and then a student on that team views that join request. It looks like this:

dboyer commented 2 years ago

Confirming that page looks correct on QA too!