search

Iridescent-CM / technovation-app

The team submission platform for the Technovation Challenge
https://technovationchallenge.org
GNU General Public License v3.0
7 stars 4 forks source link

Update judge text in the judge submissions tab for virtual judges / verify text for rpe and virtual judges is correct on all tabs #3907

Closed viviancan closed 1 year ago

viviancan commented 1 year ago

I noticed the text on the judge submissions tab for virtual judges is incorrect CleanShot 2023-04-05 at 15.18.33@2x.png

There should not be reference to "assigned submissions" or "chapter ambassadors"

viviancan commented 1 year ago

Sort of related to #3824 - just a different tab!

dboyer commented 1 year ago

@viviancan Can we just take out the "Submissions to Score" header and text below if there aren't any assigned scores and just have the green "start a new score" button? Or do we need to have that header there?

I'm wondering if that header being there is fall out from #3869

viviancan commented 1 year ago

Yes, we can remove and update the text. I think that text should really only be displayed if they are an RPE judge. The submissions to score table should only display for virtual judges once they (virtual judges) have started a new score or if the virtual judge has been manually assigned a submission.

dboyer commented 1 year ago

Agreed!

dboyer commented 1 year ago

Confirming the text is now correct for virtual judges. I checked for both judges with and without admin assigned submissions to judge.