Lock down Chapter Admin Activity until ChA is onboarded

[shaun-technovation]

A chapter ambassador should not be able to access Chapter Admin Activity (or any page in the Chapter Admin Activity section) without being fully onboarded.

• [x] Create methods to track onboarded status
  • [x] Chapter Ambassador onboarded
  • [x] Chapter Info completed
  • [x] Program Info completed
• [x] Create controller filter/action to lock down chapter admin activity
  • [x] Bypass filter for onboarding pages
• [x] Update specs
  • Specs are failing b/c things aren't accessible now unless the ChA and chapter are fully onboarded

[dboyer]

In order to access chapter admin activity, the following steps are required:

• Chapter legal agreement signed
• The individual ChA must have completed all four ChA onboarding steps
• The chapter details are filled out (public info, location, program info)

The outline of the workflow is here

[shaun-technovation]

Regarding these steps:

• The chapter details are filled out (public info, location, program info)

For public info - chapter name and program summary would need to be filled out? For location - organization HQ location would need to be filled out? For program info - which questions need to be answered? All of them?

[dboyer]

• For public info - chapter name and program summary would need to be filled out?

All fields must be completed including at least one program link.

• For location - organization HQ location would need to be filled out?

Yes, for now. Eventually when we add in location that will need to be filled out too.

• For program info - which questions need to be answered? All of them?

All questions are required except for "If you are planning a Launch Event or info session please share the date." ChAs may partially fill out the form and return to it later or edit it during the season, but all questions must be filled out (except for launch event) in order for this task to be checked out and for the ChA to get access to the admin activity.

[shaun-technovation]

Just a brief update for this one, I have a WIP up for this, but I'm still working on failing tests; tests are failing because a chapter ambassador (and their chapter) needs to be fully onboarded to access pages now that previously didn't have this restriction. And to make a fully onboarded chapter ambassador and chapter for the tests requires quite a bit of work to make the factories and associations (which are lacking for a lot of the new work we've been doing).

[shaun-technovation]

A few notes for this one:

• In order for a ChA to be able to access the chapter admin area, they need five checkmarks, right now these are the ones hooked up:
  • Under Dashboard:
  • Background check
  • Memorandum of Understanding
  • Under Chapter Profile
  • Pubic Info
  • Chapter Location
  • Program Info
  • The chapter legal agreement is also required, but there isn't a checkmark for that that a ChA can see
• All pages in the chapter admin area will not be accessible unless the ChA and chapter are onboarded - all existing and new chapter ambassador pages/controllers will also be covered - I had to opt-out existing pages/controllers used for onboarding
  • Something to keep an eye out for, if an existing page used for onboarding should be accessible but isn't, I missed it and will need to be updated

Also while working on this I had to update a lot of the tests to make a ChA and their chapter onboarded. Something that arose while updating the specs:

• Will chapters ever be deleted? And if so, what should happen to their data?

[shaun-technovation]

I also created the concept of chapter onboarding while working on this and created two followup issues:

• 4780 to add a chapter onboarded column to the database, it's pretty expensive to check all of the dependencies every time, adding it to the database will help with that

• 4781 to display the chapter onboarding steps in the admin area

[shaun-technovation]

I already have really big PR for this work, so I added #4786 for adding "viewing community connections" as a requirement to be able to access the chapter admin activity area.

[shaun-technovation]

This is on Preview, but no need to test this until I get #4779 and #4791 completed.

[shaun-technovation]

This can be tested now on Preview.

In order to access Chapter Admin Activity a chapter ambassador needs seven items completed:

• Four on the Dashboard:
  • Background Check
  • Chapter Ambassador Training
  • Memorandum of Understanding
  • Community Connections
• Three on Chapter Profile:
  • Pubic Info
  • Chapter Location
  • Program Info

[dboyer]

Tested on preview and confirmed I could not access the chapter activity admin page without confirming:

• ChA MOU
• ChA background check
• ChA training
• ChA community connections page
• Chapter public info
• Chapter program info
• Chapter location info

I also confirmed that the chapter affiliation agreement is necessary to access the chapter admin pages. #4827 supports adding it as a chapter onboarding task.