Rename ChA and chapter legal documents

Iridescent-CM / technovation-app

The team submission platform for the Technovation Challenge

https://technovationchallenge.org

GNU General Public License v3.0

7 stars 4 forks source link

Rename ChA and chapter legal documents #4719

Closed shaun-technovation closed 1 week ago

shaun-technovation commented 4 months ago

Throughout the code base, legal documents are referred to as MOU, "memorandum of understanding", legal documents... Make all of this consistent:

For chapter ambassadors their legal document is referred to as a "legal agreement".
For chapters their legal document is referred to as an "affiliation agreement".

Related to #4691

DEPLOY NOTES:

Remove this Heroku setting on Production: DOCUSIGN_CHAPTER_AMBASSADOR_LEGAL_AGREEMENT_TEMPLATE_ID

shaun-technovation commented 1 month ago

This is on QA. One thing to look out for is any names that I missed that would need updating.

dboyer commented 1 month ago

On QA

Chapter Affiliation Agreement is listed:

On the chapter admin page on the button to send the doc to a legal contact or void it
On the chapter admin that lists the agreement's status and the years for which it is valid
On the chapter tab of the ChA onboarding dashboard

Chapter Volunteer Agreement is listed:

On the onboarding tab of the ChA dashboard
On the ChA admin page

@shaun-technovation The preference from PT would be to have the ChA's agreement called the "Chapter Volunteer Agreement." I believe that would need to be changed:

In the left sidebar on the ChA onboarding page
In the header of the ChA legal agreement tab
In the list of onboarding tasks on the ChA participant admin page

dboyer commented 3 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @shaun-technovation @viviancan

shaun-technovation commented 3 weeks ago

@shaun-technovation The preference from PT would be to have the ChA's agreement called the "Chapter Volunteer Agreement."

Wow, total facepalm on my part, I totally didn't see this comment! 🤦 Anywho, I have a PR up for this now. 👍

shaun-technovation commented 3 weeks ago

Todo:

[x] Rename Docusign Heroku setting on QA
[x] Rename Docusign Heroku setting on Preview
[x] Rename Docusign Heroku setting on Production

shaun-technovation commented 2 weeks ago

This is on QA.

dboyer commented 2 weeks ago

Confirmed on QA that I see the text as "chapter volunteer agreement" in the following places:

In the left sidebar on the ChA onboarding page
In the header of the ChA legal agreement tab
In the list of onboarding tasks on the ChA participant admin page

shaun-technovation commented 2 weeks ago

Todo:

[x] Rename Docusign Heroku setting on QA

[x] Rename Docusign Heroku setting on Preview

[x] Rename Docusign Heroku setting on Production

I updated QA and Preview. For Production, I added the new, renamed Heroku config setting, but the old setting can't be removed until after we deploy.

shaun-technovation commented 2 weeks ago

For Production, I added the new, renamed Heroku config setting, but the old setting can't be removed until after we deploy.

This is done, I removed the old setting on Production.

dboyer commented 1 week ago

Confirming I see the updated language to "chapter volunteer agreement" on production.