Chapter MOU, delete/void MOU functionaity

Iridescent-CM / technovation-app

The team submission platform for the Technovation Challenge

https://technovationchallenge.org

GNU General Public License v3.0

7 stars 4 forks source link

Chapter MOU, delete/void MOU functionaity #4726

Closed shaun-technovation closed 2 weeks ago

shaun-technovation commented 3 months ago

If an MOU has been sent (and not signed yet) and for some reason it needs to be deleted or re-sent; we need a way to delete it and void it on the DocuSign side and delete our record locally.

dboyer commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @shaun-technovation @viviancan

shaun-technovation commented 1 month ago

This one is on QA, we should now have basic void functionality. The void button (which still says MOU and will get updated in #4719) will only be displayed if the document hasn't been signed yet.

There isn't a way to tell if the void was successful or not. If there was an error it would get displayed in our Slack channel. For future work maybe we could make this work like CSV exports, where a success/failure message gets displayed. And/or if we add a datagrid, we could see if a document was voided or not.

dboyer commented 1 month ago

Tested on QA and found:

Void MOU button did not appear until the MOU had been sent
I clicked the Void button and saw a message at the top of the page indicating it was voided
As the intended signer, I received an email saying the doc was voided
However, when I tried to access the MOU in the original email I received with instructions to sign it, I was still able to click through and sign that document. The admin page for the chapter says it was signed.

What's interesting is that when I sent the legal contact the MOU, the legal contact received two emails. After I voided the MOU, the link in the first email didn't work anymore but the link in the second email did. I'll forward those emails to you @shaun-technovation

shaun-technovation commented 1 month ago

What's interesting is that when I sent the legal contact the MOU, the legal contact received two emails. After I voided the MOU, the link in the first email didn't work anymore but the link in the second email did. I'll forward those emails to you @shaun-technovation

I think the issue is that two documents got sent. Hopefully this will get addressed in #4917, which will disable the send button after it has been clicked, hopefully this will prevent multiple documents being sent.

dboyer commented 4 weeks ago

I tested this again and I'm not seeing two emails this time. I think it may be due to double sends. Voiding is working as expected!