search

Iridescent-CM / technovation-app

The team submission platform for the Technovation Challenge
https://technovationchallenge.org
GNU General Public License v3.0
7 stars 4 forks source link

Adds training module modals to the ChA training tab in onboarding #4797

Closed viviancan closed 3 days ago

viviancan commented 1 week ago

Refs #4792

This PR adds the training module links & modals to the training & checkpoint tab for ChA onboarding.

It would be nice if the training modules were more like a "checklist" and the quiz would only be available once all trainings were completed. Not a must-have but a nice to have!

Screenshot 2024-06-20 at 1 58 02 PM Screenshot 2024-06-20 at 1 58 08 PM
shaun-technovation commented 6 days ago

Looks like this branch needs to be rebased against the preview branch and then I can review it. 👍

viviancan commented 6 days ago

Looks like this branch needs to be rebased against the preview branch and then I can review it. 👍

@shaun-technovation This is updated!

shaun-technovation commented 3 days ago

Some food for thought...

Naming these Heroku ENVs as:

CHAPTER_AMBASSADOR_TRAINING_SLIDES_MODULE_1_URL CHAPTER_AMBASSADOR_TRAINING_SLIDES_MODULE_2_URL etc.

Vs. something like:

CHAPTER_AMBASSADOR_TRAINING_PROGRAM_OVERVIEW_URL CHAPTER_AMBASSADOR_TRAINING_CURRICULUM_URL etc.

Naming them with numbers, for me it suggests that the URLs can be reordered (I want to change URL three to be number one now), but this wouldn't work as intended.

Naming them for what the are, for me it suggests I can update the URL for a certain training module, which would work as intended. Clearer and less confusion, IMHO.

Also, including SLIDES seems unnecessary, it's just a link to some material. Although I could see it being useful if one training module has both slides and a video and we need to distinguish between them.

Anywho, FWIW. 😄

viviancan commented 3 days ago

Some food for thought...

Naming these Heroku ENVs as:

CHAPTER_AMBASSADOR_TRAINING_SLIDES_MODULE_1_URL CHAPTER_AMBASSADOR_TRAINING_SLIDES_MODULE_2_URL etc.

Vs. something like:

CHAPTER_AMBASSADOR_TRAINING_PROGRAM_OVERVIEW_URL CHAPTER_AMBASSADOR_TRAINING_CURRICULUM_URL etc.

Naming them with numbers, for me it suggests that the URLs can be reordered (I want to change URL three to be number one now), but this wouldn't work as intended.

Naming them for what the are, for me it suggests I can update the URL for a certain training module, which would work as intended. Clearer and less confusion, IMHO.

Also, including SLIDES seems unnecessary, it's just a link to some material. Although I could see it being useful if one training module has both slides and a video and we need to distinguish between them.

Anywho, FWIW. 😄

Great point! 👍 I will remove "slides" from the env variable name. I can see what you mean about how the numbers suggest that they can be reordered, but the numbers also indicate that the modules go in a specific order (which right now, these modules are sequential and go in this order). I will wait to update the names until I have a final answer from PT. It is also possible that the title names will change before this goes live!