Update onboarding status for off-platform chapter affiliation agreements

Iridescent-CM / technovation-app

The team submission platform for the Technovation Challenge

https://technovationchallenge.org

GNU General Public License v3.0

7 stars 4 forks source link

Update onboarding status for off-platform chapter affiliation agreements #5057

Open shaun-technovation opened 3 weeks ago

shaun-technovation commented 3 weeks ago

When an off-platform chapter affiliation agreement is created it is not triggering an update to the overall onboarding status.

shaun-technovation commented 2 weeks ago

This one is now on QA.

dboyer commented 1 day ago

Tested on QA and confirmed that when I set an off-platform chapter agreement, the onboarding status updates on the admin page and on the ChA dashboard.

@shaun-technovation I tested on /admin/chapters/562 on QA and the overall status continued to say it was not complete even though I had 8 green check marks.

Screen Shot 2024-10-22 at 4.52.10 PM.png

Screen Shot 2024-10-22 at 4.50.12 PM.png

shaun-technovation commented 1 day ago

@shaun-technovation I tested on /admin/chapters/562 on QA and the overall status continued to say it was not complete even though I had 8 green check marks.

Hmm, do you remember what the last onboarding step you took was?

dboyer commented 1 day ago

Just replicated it for /admin/chapters/661 and got the same result. Here are the steps I followed:

ChA volunteer agreement
ChA training
ChA Community Connections
Chapter public info
Chapter location
Chapter program info
ChA background check (use exempt button)
Chapter agreement (use offplatform option)

shaun-technovation commented 1 day ago

I verified locally that the an off-platform chapter affiliation agreement is triggering the onboarding check. If that was the last step it should have triggered an onboarding check (I didn't actually verify the this part though).

I have a hunch adding or editing a location isn't triggering an onboarding check; it's hard to verify in the code b/c there are so many layers to the locations code, but i see a method in there maybe_run_account_updates; we added chapters to the existing locations flow, but seems like it was designed for accounts. Anywho, if that was the last step then this would line up...

shaun-technovation commented 1 day ago

I didn't see your message before I posted mine^. Anywho, I verified on QA that the chapter affiliation agreement isn't triggering the onboarding check - I deleted the off-platform agreement for the chapter (661) and re-created it and it didn't trigger the onboarding check. I'll dig in some more.