search

IridiumIO / CompactGUI

Transparently compress active games and programs using Windows 10/11 APIs
GNU General Public License v3.0
5.11k stars 237 forks source link

Non-Steam Games can't be added to community submission results? #458

Closed Adhjie closed 3 months ago

Adhjie commented 3 months ago 
          Yeah the submit results button only shows up for Steam games - this is intentional

Originally posted by @Iridium-IO in https://github.com/IridiumIO/CompactGUI/issues/266#issuecomment-1177216602

Why non-steam games results can't be submitted, and added to skipped poor compressed files or fixed by a new release (by making the compression compatible)? edit: wording To add, last time if I compress without skipp poor compatibility files, I can't play steam games e.g., Snowbreak, VEGA Conflict. Emulator games in MuMu emulator e.g., Aether Gazer Global & Chinese version, memento mori, probably the whole emulator doesn't load when compressed?

Iridium-IO commented 3 months ago

That's intentional because it's a pain in the neck trying to moderate submissions otherwise. There's already over 50,000 steam submissions that get sifted through

Adhjie commented 3 months ago

Is there a way to resolve this using a DIY method, e.g., if a (FL)OSS app can be built from source. Is it possible to bug fix this in a fork of CompactGUI, and then merge it with the main repo, or if it's easier to do a pull request by each user? Oh yeah, what's the license for this app? If this is non-reproducible as a fork, then maybe PR is the only way to submit bugfixes.

Iridium-IO commented 3 months ago

It's not a bug.

Consider this: what happens when someone submits results of a folder called "Minecraft", but the contents of that folder are actually from Red Dead Redemption?

Adhjie commented 3 months ago

why not open a pull request then? make a documentation on how each player could submit their own game folders as a PR?

Iridium-IO commented 3 months ago

I don't think you understand the sheer scope of the problem. fifty thousand steam games are already submitted that I can automate verification for.

I cannot do that for any random folders people have. PRs are a terrible idea for that. Having thousands of PRs for random folders people have? I think not.

Adhjie commented 3 months ago

Wait, I thought PR is made by each user, akin to branch git pushing to main repo after consultation with every developer of such repo (fork merged to main repo also makes sense)? This is different from asking for feature to be made in GitHub through feature request or GitHub issue to be fixed as bug fix, right?

Iridium-IO commented 3 months ago

I still have to approve the PR merges though

Adhjie commented 2 months ago

Alright, I understand now. Take it easy, I should've known OSS apps are mostly hobby. Thanks for the app and its update, btw (#Dev appreciation post). Other alternative to this is not updated anymore because the developer is bus with their RL job (Compactor). Though, I do feel there are good aspects of Compactor that could be asked to be implemented here. Like how it handles big files better, etc. I think a collaboration is possible in OSS apps' development community? (This should be in a feature request instead of issue, I would say) edit: is this worthy to be a label in this repo too? https://github.com/aistra0528/Hail/labels/PR%20welcome ^ I mean, when this got big; and there are a lot of devs, you won't be alone in approving them (staying optimistic here).