IrisShaders / Iris

A modern shaders mod for Minecraft compatible with existing OptiFine shader packs
https://irisshaders.dev
GNU Lesser General Public License v3.0
3.36k stars 641 forks source link

import shader config file breaks minecraft as a window #1258

Closed inikishev closed 2 years ago

inikishev commented 2 years ago

What happened?

Pressing "import shader config file breaks" made it so that it showed me the selection window, but I couldn't click anything in it as it would revert back to fullscreen minecraft but with an inactive file selection window on top. In particular I couldn't close the window to get out of the situation. Since my cursor didn't work I couldn't exit minecraft. Keyboard worked in minecraft, so by pressing "esc" and navigating back to the game and typing "/kick player" I kicked myself, but that didn't help. So I had to kill minecraft from task manager.

Screenshots

No response

Relevant log output

No response

Minecraft Version

1.18.1

Iris Version

iris-mc1.18.1-1.2.0-pre.jar

Sodium Version

sodium-fabric-mc1.18.1-0.4.0-alpha6+build.14.jar

Operating System

Windows 11

What is your GPU?

NVidia GeForce GTX 1650 (intel optimus)

Java Version

JAVA 16!!!

Additional context

i have 2 monitors

AlsoSylv commented 2 years ago

We need a log and screenshot

inikishev commented 2 years ago

We need a log and screenshot

log https://gist.github.com/idkman2021/0a6798029f7a2fb56e4b2245f78c2f7e Screenshot is minecraft with file selection window on top. I didn't include them because I did but it said "65536 characters exceeded" and erased my description so I had to edit my issue to reenter it

Pectacular commented 2 years ago

How are you using Java 16 with Minecraft 1.18.1?

inikishev commented 2 years ago

How are you using Java 16 with Minecraft 1.18.1?

I might be wrong, but I use default java and the github issue maker told me 1.18.1 uses java 16

Pectacular commented 2 years ago

Do you use the vanilla launcher? If you do, then you're probably using Java 17.0.1

inikishev commented 2 years ago

Do you use the vanilla launcher? If you do, then you're probably using Java 17.0.1

I use vanilla launcher so probably java 17

helpimnotdrowning commented 2 years ago

Still having the same issue in the just-released v1.2.4.

I clicked on the "export config" button of a shader pack (which opened a file picker) and switched back into (fullscreen) MC. Here, whenever I tried to click anywhere within the Minecraft window, it would flash the file picker before the MC window minimizes itself and the file picker dissapears (doesn't show up in the alt-tab menu). Killing and restarting explorer does nothing, the only way to fix this is to close Minecraft.

While the game is like this, the game still looks fine (world progresses like normal, animations, mobs, shaders) and still accepts most input, like movement (WASD), chat/commands, and even mouse movements to move the camera/player head. Right clicking, however, will cause it to minimize all over again, making the only ways out of this either:

Nothing special is logged:

[20:18:54] [REI-ReloadPlugins/INFO]: Reloaded Plugin Manager [REIClientPlugin] with 1371 entries, 1597 displays, 1 display visibility predicates, 21 categories (Crafting, Smelting, Smoking, Blasting, Campfire, Stone Cutting, Fuel, Brewing, Composting, Stripping, Smithing, Anvil, Beacon Base, Beacon Payment, Tilling, Pathing, Waxing, Wax Scraping, Oxidizing, Oxidation Scraping, Information), 4 exclusion zones and 3 overlay deciders in 235ms.
[20:18:54] [REI-ReloadPlugins/INFO]: Reloading Plugin Manager [REIServerPlugin] stage [END], registered 3 plugins: DefaultRuntimePlugin [roughlyenoughitems], FabricFluidAPISupportPlugin, DefaultPlugin [roughlyenoughitems]
[20:18:54] [REI-ReloadPlugins/INFO]: Reloaded Plugin Manager [REIServerPlugin] with 4 menu infos in 5ms.
[20:18:54] [Render thread/INFO]: Received secret
[20:18:54] [Render thread/INFO]: Connecting to server: '127.0.0.1:49913'
[20:18:54] [VoiceChatAuthenticationThread/INFO]: Trying to authenticate voice connection
[20:18:54] [VoiceChatPacketProcessingThread/INFO]: Successfully authenticated player baa0a8cd-2687-4778-bfc4-685dbef98219
[20:18:54] [VoiceChatConnectionThread/INFO]: Server acknowledged authentication
[20:18:54] [VoiceChatConnectionThread/INFO]: Clearing unused audio channels
[20:18:55] [Render thread/INFO]: Refreshing cached entry list texture...
[20:18:55] [Render thread/INFO]: Loaded 0 advancements
[20:18:59] [Render thread/INFO]: [CHAT] Saved screenshot as 2022-04-26_20.18.57.png
// export -> switch back to mc -> problem arises here
[20:19:43] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2004ms or 40 ticks behind
[20:20:01] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 3353ms or 67 ticks behind

I actually can't use screencapture (OBS) to record this, as it either shows a black screen or this image, where it freeze frames on the first frame of the game, though it does show the bugged window (incase I didn't put it in earlier, the file picker never shows up again after going back into MC, except for the quick flash on clicking)

To replicate (written better):

  1. Open shader menu
  2. Select a shaderpack, go to Shader Pack Settings
  3. Click the export button on the top right (the import button will also probably do this)
  4. Once it opens the file picker, switch back into Minecraft
  5. Attempt to left click anywhere, it will minimize Minecraft, though using keyboard navigation, typing, and looking around with the mouse work just fine.

Using:

helpimnotdrowning commented 2 years ago

A workaround I've just discovered is: while you are kicked out of MC (it is minimized), right click on the taskbar icon and click "close window" image This will fullscreen Minecraft and put the bugged window in the foreground image , where you can now click "cancel" to close the file picker, making Minecraft playable again, no game-restart needed ("close window" doesn't close MC, it just makes the bugged file picker visible)

Felix14-v2 commented 2 years ago

Have you tried to reproduce this issue with Borderless Mining installed? I have a hunch that this mod can help.

Felix14-v2 commented 2 years ago

@coderbot16, is it possible to disable the prevention of import/export settings if any mod implementing borderless mode is installed? It looks like they are fixing the issue (at least in my case).

coderbot16 commented 2 years ago

That's potentially an option, but it looks like Borderless Mining allows the borderless mode to be turned off, so detection would be complex.