IrisShaders / Iris

A modern shaders mod for Minecraft compatible with existing OptiFine shader packs
https://irisshaders.dev
GNU Lesser General Public License v3.0
3.34k stars 632 forks source link

Spiders and endermen have black texture when running Iris v1.2.5 and Sodium v0.4.1 on Minecraft 1.18.2 #1517

Closed U5B closed 1 year ago

U5B commented 2 years ago

What happened?

Spiders and endermen have black texture instead their normal texture. However, downgrading Iris to v1.2.4 fixes the issue so it has to be caused by a relatively recent change.

Screenshots

image image

Relevant log output

N/A

Minecraft Version

1.18.2

Iris Version

iris-mc1.18.2-1.2.5.jar

Sodium Version

sodium-fabric-mc1.18.2-0.4.1+build.15

Operating System

Windows 10

What is your GPU?

Nvidia GeForce GTX 1060

Java Version

Java 16

Additional context

No response

coderbot16 commented 2 years ago

Do you have any other mods and resource packs? You should try running with only Iris and Sodium and if it still happens you should post a log.

U5B commented 2 years ago

Do you have any other mods and resource packs? You should try running with only Iris and Sodium and if it still happens you should post a log.

I should've specified that I used only Sodium and Iris. I was testing with a resource pack. (https://github.com/U5B/MonumentaRP-NoOptiFine/releases/tag/v1.1.0) It relys on CIT Resewn, ETF and CEM for custom mobs, but I didn't have those mods installed when I was doing my tests above.

It doesn't happen in vanilla however and doesn't happen to Faithful so it probably could be a resource pack error.

Lolothepro commented 2 years ago

https://faithfulpack.net/classicfaithful/32x-programmer-art Occurs with Faifhul. This happens in all versions of Iris for Minecraft 1.16.5, and from Iris 1.2.5 for Minecraft 1.17+.

Lolothepro commented 2 years ago

seems to be caused by https://github.com/IrisShaders/Iris/commit/0767f859d87e10b7db64e5c0c46dc6e9010b654d

Lolothepro commented 2 years ago

https://github.com/IrisShaders/Iris/blob/trunk/src/main/java/net/coderbot/iris/mixin/rendertype/MixinRenderType_FixEyesTranslucency.java This should only be active if a shader is enabled. (https://github.com/sp614x/optifine/issues/4578) (but maybe Iris developers should add a fix that doesn't cause the Optifine bug?)

coderbot16 commented 2 years ago

That doesn't really solve the problem, since it just makes it look like it's caused by the shader instead of the resource pack.

IMS212 commented 1 year ago

This should be fixed with 1.4.1, can someone check?

Lolothepro commented 1 year ago

This should be fixed with 1.4.1, can someone check?

fixed

Iris 1.4.0: 2022-11-03_21 33 33

Iris 1.4.1pre: 2022-11-03_21 34 30