IrisShaders / Iris

A modern shaders mod for Minecraft compatible with existing OptiFine shader packs
https://irisshaders.dev
GNU Lesser General Public License v3.0
3.36k stars 640 forks source link

Iris wrongly using old lighting for CPHSBC shader + black block breaking animation #2062

Closed voxel-ate closed 5 months ago

voxel-ate commented 1 year ago

What happened?

CPHSBC shader by CrushedPixel (link to vid: https://www.youtube.com/watch?v=zgGl-xLlOcs&t=1s)

Iris seems to render CPHSBC shader differently to optifine, where less shading is present and the block breaking animation is fully opaque and dark instead of having transparency. This might not be worth looking into, but I would appreciate if you did or are able to suggest a remedy to the issue, thanks

Screenshots

Optifine 1.20.1: Base Profile Screenshot 2023 07 28 - 23 33 34 60 Base Profile Screenshot 2023 07 28 - 23 33 18 60

Iris 1.20: Minecraft Screenshot 2023 07 28 - 23 15 40 80 Minecraft Screenshot 2023 07 28 - 23 13 38 83

Log output

[23:11:59] [main/INFO]: Loading Minecraft 1.20 with Fabric Loader 0.14.21 [23:11:59] [main/INFO]: Loading 58 mods:

Minecraft Version

1.20

Iris Version

iris-mc1.20-1.6.4

Operating System

Win 10

What is your GPU?

Nvidia Geforce GTX 1650

Additional context

No response

mrjasonn commented 8 months ago

The black block breaking animation is still a thing even with an empty shader to trick Iris into using "New Lighting", so this black block breaking animation thing is not specific to this shader, however people have managed to find a way around this by adding code into their shader to mitigate this. This is still true on 1.20.4. @IMS212 please investigate this thanks.

Lolothepro commented 8 months ago

The black block breaking animation is still a thing even with an empty shader to trick Iris into using "New Lighting", so this black block breaking animation thing is not specific to this shader, however people have managed to find a way around this by adding code into their shader to mitigate this. This is still true on 1.20.4. @IMS212 please investigate this thanks.

This is already fixed in the next version of Iris