search

IrisShaders / Iris

A modern shaders mod for Minecraft compatible with existing OptiFine shader packs
https://irisshaders.dev
GNU Lesser General Public License v3.0
3.32k stars 624 forks source link

The translucent overlays of Masa's mods are too opaque/bright #218

Open coderbot16 opened 3 years ago

coderbot16 commented 3 years ago
alex3236 commented 2 years ago

Any progress?

JuneTheMistborn commented 1 year ago

Is this something that is being worked on or set aside for now?

coderbot16 commented 1 year ago

This is not being worked on because it's not clear how it could be fixed in Iris. The root issue is that due to the way that shader packs do HDR color calculations, very bright things also tend to become much more opaque than they should be. This likely just needs to be fixed in the shader pack by properly adjusting the alpha value for the brightness.

The only way I know of to fix it in Iris would be to hardcode things such that solid translucent things that lack lighting information (such as the overlays in Masa's mods) are drawn with reduced brightness instead of being fully lit, while other things that lack lighting information are drawn with full brightness as Iris currently does.

coderbot16 commented 1 year ago

However, I should note that aside from overlays being too opaque/bright, all other issues should have been fixed in Iris 1.2.5 from last year.