IrisShaders / Iris

A modern shaders mod for Minecraft compatible with existing OptiFine shader packs
https://irisshaders.dev
GNU Lesser General Public License v3.0
3.37k stars 640 forks source link

Issue using the vanilla takePanorama() method #2196

Open Fridtjof-DE opened 11 months ago

Fridtjof-DE commented 11 months ago

What happened?

A made a small mod that makes the vanilla game's takePanorama() method usable. It works as intended but however as soon as I start using IrisShaders the six panorama screenshots just show the sky color. When testing I was using no shader pack. The method is located at net.minecraft.client.MinecraftClient.takePanorama() The mod

Screenshots

iris_panorama_issue

Log output

No response

Minecraft Version

Minecraft 1.20.4

Iris Version

iris-mc1.20.4-1.6.14.jar

Operating System

Windows 10 Home 19045.3803

What is your GPU?

Nvidia GeForce GTX 750Ti

Additional context

No response

coderbot16 commented 11 months ago

The vanilla method could need re-implementation to ensure that all the needed Iris state is properly set up. One complexity for high quality panoramas is that it is likely necessary to render multiple frames at each perspective to give time for things like temporal anti-aliasing to settle down and give a properly anti-aliased image. This is similar to the issues with Immersive Portals where AA can't settle down as easily in some cases since it's effectively the camera jumping back and forth very fast from the shader pack perspective.

Gazmanovich commented 8 months ago

The vanilla method could need re-implementation to ensure that all the needed Iris state is properly set up. One complexity for high quality panoramas is that it is likely necessary to render multiple frames at each perspective to give time for things like temporal anti-aliasing to settle down and give a properly anti-aliased image. This is similar to the issues with Immersive Portals where AA can't settle down as easily in some cases since it's effectively the camera jumping back and forth very fast from the shader pack perspective.

So... Fix in next update?

coderbot16 commented 8 months ago

Unlikely as the only current active developer of Iris is IMS212, and they are focused on other development work.

AdamCalculator commented 5 months ago

up. 1.20.1 also not working