Closed McArdellje closed 3 months ago
yeah this should be fixed
not sure if this is fixed completely
Looks like that should have fixed it for the if(bool, vecN, vecN)
variant but there is still no support for the vararg versions such as if(bool, vecN, bool, vecN, vecN)
What happened?
any if() call that is of the signature
if(bool, vecN, vecN)
will cause a warning "Failed to resolve uniform NAME, reason: Ambiguity", this is because the code in parsing/IrisFunctions.java that is supposed to handle varargs (such asif(bool, vecN, bool, vecN, vecN)
) due to it just being a copy of the non-vararg code for vectorif
s therefore it adds many duplicate function calls for if with the same signature ofif(bool, vecN, vecN)
Screenshots
No response
Log output
Mod Table Version: 2 Plugin Types: {quilted_fabric_loader=[Fabric], quilt_loader=[Quilt, Builtin]}
Minecraft Version
1.21.0
Iris Version
iris-1.7.1+mc1.21.jar
Operating System
Windows 11
What is your GPU?
Nvidia GeForce GTX 1070
Additional context
[21:35:07] [Render thread/INFO]: Profile: Custom (+0 options changed by user) [21:35:07] [Render thread/INFO]: Using shaderpack: mc_shader [21:35:07] [Render thread/INFO]: Creating pipeline for dimension minecraft:the_nether [21:35:07] [Render thread/WARN]: Failed to resolve uniform Light1_Direction, reason: Ambiguity, old: vec3 (bool, vec3, vec3) (priority: 0, pure:yes) new: vec3 (bool, vec3, vec3) (priority: 0, pure:yes) ( = FunctionCall{if {[FunctionCall{in {[Id{biome_category}, Number{16}]} }, FunctionCall{vec3 {[UnaryExpr{negate {Number{0.16169}} }, UnaryExpr{negate {Number{0.808452}} }, Number{0.565916}]} }, FunctionCall{vec3 {[UnaryExpr{negate {Number{0.16169}} }, Number{0.808452}, Number{0.565916}]} }]} }) java.lang.RuntimeException: Ambiguity, old: vec3 (bool, vec3, vec3) (priority: 0, pure:yes) new: vec3 (bool, vec3, vec3) (priority: 0, pure:yes) at kroppeb.stareval.resolver.ExpressionResolver.resolveCallExpressionInternal(ExpressionResolver.java:89) ~[iris-1.7.1mc1.21.i0:0/:?] at kroppeb.stareval.resolver.ExpressionResolver.resolveCallExpression(ExpressionResolver.java:140) ~[iris-1.7.1mc1.21.i0:0/:?] at kroppeb.stareval.resolver.ExpressionResolver.resolveExpressionInternal(ExpressionResolver.java:194) ~[iris-1.7.1mc1.21.i0:0/:?] at kroppeb.stareval.resolver.ExpressionResolver.resolveExpression(ExpressionResolver.java:50) ~[iris-1.7.1mc1.21.i0:0/:?] at net.irisshaders.iris.uniforms.custom.CustomUniforms.(CustomUniforms.java:62) ~[iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.uniforms.custom.CustomUniforms$Builder.build(CustomUniforms.java:333) ~[iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.uniforms.custom.CustomUniforms$Builder.build(CustomUniforms.java:344) ~[iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.pipeline.IrisRenderingPipeline.(IrisRenderingPipeline.java:264) ~[iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.Iris.createPipeline(Iris.java:578) ~[iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.pipeline.PipelineManager.preparePipeline(PipelineManager.java:33) [iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.Iris.reload(Iris.java:529) [iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.Iris.toggleShaders(Iris.java:186) [iris-1.7.1mc1.21.i0:0/:?]
at net.irisshaders.iris.Iris.handleKeybinds(Iris.java:159) [iris-1.7.1mc1.21.i0:0/:?]
at net.minecraft.class_310.handler$zbh000$iris$onTick(class_310.java:3673) [transformed-mod-minecraft-v1.21.jar:?]
at net.minecraft.class_310.method_1574(class_310.java:2012) [transformed-mod-minecraft-v1.21.jar:?]
at net.minecraft.class_310.method_1523(class_310.java:1246) [transformed-mod-minecraft-v1.21.jar:?]
at net.minecraft.class_310.method_1514(class_310.java:882) [transformed-mod-minecraft-v1.21.jar:?]
at net.minecraft.client.main.Main.main(Main.java:256) [transformed-mod-minecraft-v1.21.jar:?]
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?]
at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?]
at org.quiltmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:557) [quilt-loader-0.26.0.jar:?]
at org.quiltmc.loader.impl.launch.knot.Knot.launch(Knot.java:84) [quilt-loader-0.26.0.jar:?]
at org.quiltmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:28) [quilt-loader-0.26.0.jar:?]
at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100) [NewLaunch.jar:?]
at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129) [NewLaunch.jar:?]
at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) [NewLaunch.jar:?]