IrisShaders / Iris

A modern shaders mod for Minecraft compatible with existing OptiFine shader packs
https://irisshaders.dev
GNU Lesser General Public License v3.0
3.36k stars 640 forks source link

Crash upon entering a world/server with latest Distant Horizon build #2402

Open itsTyrion opened 4 months ago

itsTyrion commented 4 months ago

Minecraft Version

Minecraft 1.20.4

Iris Version

iris-1.7.2+mc1.20.4

Sodium Version

sodium-fabric-0.5.8+mc1.20.4

Operating System

Win11 24H2

What is your GPU?

GeForce GTX 1070

Java Version

Java 21

Reproduction Steps

  1. Use Sodium, Indium, Iris and the latest DistantHorizons build (tested with DistantHorizons-a899d988fc774cce195a7158b817ee5093e0ad19)
  2. Enter a world

Crash Report file and latest.log

---- Minecraft Crash Report ----
// This doesn't make any sense!

Time: 2024-07-05 19:56:22
Description: Unexpected error

java.lang.NoSuchFieldError: Class com.seibel.distanthorizons.api.methods.events.abstractEvents.DhApiBeforeBufferRenderEvent$EventParam does not have member field 'com.seibel.distanthorizons.coreapi.util.math.Vec3f modelPos'
    at net.irisshaders.iris.compat.dh.LodRendererEvents$9.beforeRender(LodRendererEvents.java:185)
    at com.seibel.distanthorizons.api.methods.events.abstractEvents.DhApiBeforeBufferRenderEvent.fireEvent(DhApiBeforeBufferRenderEvent.java:48)
    at com.seibel.distanthorizons.coreapi.DependencyInjection.ApiEventInjector.fireAllEvents(ApiEventInjector.java:144)
    at com.seibel.distanthorizons.core.render.renderer.LodRenderer.setModelViewMatrixOffset(LodRenderer.java:478)
    at com.seibel.distanthorizons.core.dataObjects.render.bufferBuilding.ColumnRenderBuffer.renderOpaque(ColumnRenderBuffer.java:261)
    at com.seibel.distanthorizons.core.render.RenderBufferHandler.lambda$renderOpaque$2(RenderBufferHandler.java:351)
    at java.base/java.lang.Iterable.forEach(Iterable.java:75)
    at com.seibel.distanthorizons.core.render.RenderBufferHandler.renderOpaque(RenderBufferHandler.java:351)
    at com.seibel.distanthorizons.core.render.renderer.LodRenderer.renderLodPass(LodRenderer.java:303)
    at com.seibel.distanthorizons.core.render.renderer.LodRenderer.drawLods(LodRenderer.java:179)
    at com.seibel.distanthorizons.core.level.ClientLevelModule.render(ClientLevelModule.java:167)
    at com.seibel.distanthorizons.core.level.DhClientLevel.render(DhClientLevel.java:99)
    at com.seibel.distanthorizons.core.api.internal.ClientApi.renderLodLayer(ClientApi.java:550)
    at com.seibel.distanthorizons.core.api.internal.ClientApi.renderLods(ClientApi.java:464)
    at com.seibel.distanthorizons.fabric.FabricClientProxy.lambda$registerEvents$5(FabricClientProxy.java:205)
    at net.minecraft.class_761.handler$zld000$fabric-rendering-v1$afterTerrainSetup(class_761.java:5216)
    at net.minecraft.class_761.method_3273(class_761.java:10271)
    at net.minecraft.class_761.method_22710(class_761.java:1020)
    at net.minecraft.class_757.method_3188(class_757.java:1098)
    at net.minecraft.class_757.method_3192(class_757.java:866)
    at net.minecraft.class_310.method_1523(class_310.java:1327)
    at net.minecraft.class_310.method_1514(class_310.java:888)
    at net.minecraft.client.main.Main.main(Main.java:265)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
    at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
    at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
    at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
    at net.irisshaders.iris.compat.dh.LodRendererEvents$9.beforeRender(LodRendererEvents.java:185)
    at com.seibel.distanthorizons.api.methods.events.abstractEvents.DhApiBeforeBufferRenderEvent.fireEvent(DhApiBeforeBufferRenderEvent.java:48)
    at com.seibel.distanthorizons.coreapi.DependencyInjection.ApiEventInjector.fireAllEvents(ApiEventInjector.java:144)
    at com.seibel.distanthorizons.core.render.renderer.LodRenderer.setModelViewMatrixOffset(LodRenderer.java:478)
    at com.seibel.distanthorizons.core.dataObjects.render.bufferBuilding.ColumnRenderBuffer.renderOpaque(ColumnRenderBuffer.java:261)
    at com.seibel.distanthorizons.core.render.RenderBufferHandler.lambda$renderOpaque$2(RenderBufferHandler.java:351)
    at java.base/java.lang.Iterable.forEach(Iterable.java:75)
    at com.seibel.distanthorizons.core.render.RenderBufferHandler.renderOpaque(RenderBufferHandler.java:351)
    at com.seibel.distanthorizons.core.render.renderer.LodRenderer.renderLodPass(LodRenderer.java:303)
    at com.seibel.distanthorizons.core.render.renderer.LodRenderer.drawLods(LodRenderer.java:179)
    at com.seibel.distanthorizons.core.level.ClientLevelModule.render(ClientLevelModule.java:167)
    at com.seibel.distanthorizons.core.level.DhClientLevel.render(DhClientLevel.java:99)
    at com.seibel.distanthorizons.core.api.internal.ClientApi.renderLodLayer(ClientApi.java:550)
    at com.seibel.distanthorizons.core.api.internal.ClientApi.renderLods(ClientApi.java:464)
    at com.seibel.distanthorizons.fabric.FabricClientProxy.lambda$registerEvents$5(FabricClientProxy.java:205)
    at net.minecraft.class_761.handler$zld000$fabric-rendering-v1$afterTerrainSetup(class_761.java:5216)
    at net.minecraft.class_761.method_3273(class_761.java:10271)
    at net.minecraft.class_761.method_22710(class_761.java:1020)
    at net.minecraft.class_757.method_3188(class_757.java:1098)

-- Uptime --
Details:
    JVM uptime: 36.787s
    Wall uptime: 28.260s
    High-res time: 26.918s
    Client ticks: 276 ticks / 13.800s
Stacktrace:
    at net.minecraft.class_310.method_1587(class_310.java:2564)
    at net.minecraft.class_310.method_54580(class_310.java:995)
    at net.minecraft.class_310.method_1514(class_310.java:911)
    at net.minecraft.client.main.Main.main(Main.java:265)
    at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470)
    at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
    at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
    at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:100)
    at org.prismlauncher.EntryPoint.listen(EntryPoint.java:129)
    at org.prismlauncher.EntryPoint.main(EntryPoint.java:70)

-- Affected level --
Details:
    All players: 1 total; [class_746['IchKnuddelDich'/47, l='ClientLevel', x=-1.50, y=69.00, z=-2.50]]
    Chunk stats: 256, 77
    Level dimension: minecraft:overworld
    Level spawn location: World: (-2,69,-3), Section: (at 14,5,13 in -1,4,-1; chunk contains blocks -16,-64,-16 to -1,319,-1), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
    Level time: 623921920 game time, 12000 day time
    Server brand: Purpur (Velocity)
    Server type: Non-integrated multiplayer server
    Tracked entity count: 1

-- Last reload --
Details:
    Reload number: 2
    Reload reason: manual
    Finished: No
    Packs: vanilla, fabric, distanthorizons, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-block-view-api-v2, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-containers-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-crash-report-info-v1, fabric-data-attachment-api-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-events-lifecycle-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-message-api-v1, fabric-mining-level-api-v1, fabric-model-loading-api-v1, fabric-models-v0, fabric-networking-api-v1, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-renderer-registries-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v0, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader, indium, iris, sodium, file/4f602-hardtop-vanillaccurate-128x-v1.9.0.zip, file/HardTop-Vanillaccurate-256x-items-mobs-v0.8.zip, file/amongus-orbs.zip, file/lever-indicator.zip, server/00000000/b64fc53f-8f95-3fa5-9014-8cfb41bef3d2

-- System Details --
Details:
    Minecraft Version: 1.20.4
    Minecraft Version ID: 1.20.4
    Operating System: Windows 11 (amd64) version 10.0
    Java Version: 21.0.3, Azul Systems, Inc.
    Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Azul Systems, Inc.
    Memory: 251844424 bytes (240 MiB) / 1543503872 bytes (1472 MiB) up to 2634022912 bytes (2512 MiB)
    CPUs: 12
    Processor Vendor: AuthenticAMD
    Processor Name: AMD Ryzen 5 5600 6-Core Processor              
    Identifier: AuthenticAMD Family 25 Model 33 Stepping 2
    Microarchitecture: Zen 3
    Frequency (GHz): 4.30
    Number of physical packages: 1
    Number of physical CPUs: 6
    Number of logical CPUs: 12
    Graphics card #0 name: NVIDIA GeForce GTX 1070
    Graphics card #0 vendor: NVIDIA (0x10de)
    Graphics card #0 VRAM (MB): 4095.00
    Graphics card #0 deviceId: 0x1b81
    Graphics card #0 versionInfo: DriverVersion=32.0.15.5599
    Memory slot #0 capacity (MB): 8192.00
    Memory slot #0 clockSpeed (GHz): 3.20
    Memory slot #0 type: DDR4
    Memory slot #1 capacity (MB): 8192.00
    Memory slot #1 clockSpeed (GHz): 3.20
    Memory slot #1 type: DDR4
    Virtual memory max (MB): 29397.59
    Virtual memory used (MB): 26225.57
    Swap memory total (MB): 13088.00
    Swap memory used (MB): 3016.25
    JVM Flags: 19 total; -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:MaxGCPauseMillis=37 -XX:+PerfDisableSharedMem -XX:G1HeapRegionSize=16M -XX:G1NewSizePercent=25 -XX:G1ReservePercent=20 -XX:SurvivorRatio=32 -XX:G1MixedGCCountTarget=3 -XX:G1HeapWastePercent=20 -XX:InitiatingHeapOccupancyPercent=10 -XX:G1RSetUpdatingPauseTimePercent=0 -XX:MaxTenuringThreshold=1 -XX:G1SATBBufferEnqueueingThresholdPercent=30 -XX:G1ConcMarkStepDurationMillis=5.0 -XX:GCTimeRatio=99 -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xms1024m -Xmx2500m
    Fabric Mods: 
        distanthorizons: Distant Horizons 2.1.3-a-dev
        fabric-api: Fabric API 0.97.1+1.20.4
            fabric-api-base: Fabric API Base 0.4.37+78d798af4f
            fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.50+82b1bb3e4f
            fabric-biome-api-v1: Fabric Biome API (v1) 13.0.17+78d798af4f
            fabric-block-api-v1: Fabric Block API (v1) 1.0.17+3e2216cb4f
            fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.5+78d798af4f
            fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.47+78d798af4f
            fabric-client-tags-api-v1: Fabric Client Tags 1.1.8+78d798af4f
            fabric-command-api-v1: Fabric Command API (v1) 1.2.42+f71b366f4f
            fabric-command-api-v2: Fabric Command API (v2) 2.2.21+78d798af4f
            fabric-commands-v0: Fabric Commands (v0) 0.2.59+df3654b34f
            fabric-containers-v0: Fabric Containers (v0) 0.1.87+df3654b34f
            fabric-content-registries-v0: Fabric Content Registries (v0) 5.0.16+78d798af4f
            fabric-convention-tags-v1: Fabric Convention Tags 1.5.11+78d798af4f
            fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.24+78d798af4f
            fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.1.5+b90db5744f
            fabric-data-generation-api-v1: Fabric Data Generation API (v1) 13.2.5+5c0133444f
            fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.63+6605d1a84f
            fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.2+09fc25014f
            fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.7.2+389931eb4f
            fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.75+df3654b34f
            fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.47+78d798af4f
            fabric-item-api-v1: Fabric Item API (v1) 2.3.0+bcdd12964f
            fabric-item-group-api-v1: Fabric Item Group API (v1) 4.0.27+ee30b13a4f
            fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.42+78d798af4f
            fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.40+df3654b34f
            fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.3.1+a67ffb5d4f
            fabric-loot-api-v2: Fabric Loot API (v2) 2.1.10+78d798af4f
            fabric-message-api-v1: Fabric Message API (v1) 6.0.6+78d798af4f
            fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.66+78d798af4f
            fabric-model-loading-api-v1: Fabric Model Loading API (v1) 1.0.9+78d798af4f
            fabric-models-v0: Fabric Models (v0) 0.4.8+9386d8a74f
            fabric-networking-api-v1: Fabric Networking API (v1) 3.1.8+2e5ac5484f
            fabric-object-builder-api-v1: Fabric Object Builder API (v1) 13.1.0+dba1195c4f
            fabric-particles-v1: Fabric Particles (v1) 1.1.8+78d798af4f
            fabric-recipe-api-v1: Fabric Recipe API (v1) 2.0.21+78d798af4f
            fabric-registry-sync-v0: Fabric Registry Sync (v0) 4.0.20+ee30b13a4f
            fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.5+78d798af4f
            fabric-renderer-indigo: Fabric Renderer - Indigo 1.5.6+d331d3144f
            fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.54+df3654b34f
            fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.43+73761d2e4f
            fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.1.2+e761c6694f
            fabric-rendering-v0: Fabric Rendering (v0) 1.1.57+df3654b34f
            fabric-rendering-v1: Fabric Rendering (v1) 3.2.1+6fd945a04f
            fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.3.15+78d798af4f
            fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.11.21+ee30b13a4f
            fabric-screen-api-v1: Fabric Screen API (v1) 2.0.18+78d798af4f
            fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.56+78d798af4f
            fabric-sound-api-v1: Fabric Sound API (v1) 1.0.18+78d798af4f
            fabric-transfer-api-v1: Fabric Transfer API (v1) 4.0.12+90f2d7b14f
            fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 5.0.15+78d798af4f
        fabricloader: Fabric Loader 0.15.10
            mixinextras: MixinExtras 0.3.5
        indium: Indium 1.0.31+mc1.20.4
        iris: Iris 1.7.2+mc1.20.4
            io_github_douira_glsl-transformer: glsl-transformer 2.0.1
            org_anarres_jcpp: jcpp 1.4.14
            org_antlr_antlr4-runtime: antlr4-runtime 4.13.1
        java: OpenJDK 64-Bit Server VM 21
        minecraft: Minecraft 1.20.4
        sodium: Sodium 0.5.8+mc1.20.4
    Loaded Shaderpack: ComplementaryUnbound_r5.2.1.zip
        Profile: Custom (+34 options changed by user)
    Launched Version: 1.20.4
    Launcher name: PrismLauncher
    Backend library: LWJGL version 3.3.1 SNAPSHOT
    Backend API: NVIDIA GeForce GTX 1070/PCIe/SSE2 GL version 3.2.0 NVIDIA 555.99, NVIDIA Corporation
    Window size: 854x480
    GL Caps: Using framebuffer using OpenGL 3.2
    GL debug messages: 
    Using VBOs: Yes
    Is Modded: Definitely; Client brand changed to 'fabric'
    Universe: 400921fb54442d18
    Type: Client (map_client.txt)
    Graphics mode: fancy
    Render Distance: 3/13 chunks
    Resource Packs: vanilla, fabric, file/4f602-hardtop-vanillaccurate-128x-v1.9.0.zip (incompatible), file/HardTop-Vanillaccurate-256x-items-mobs-v0.8.zip (incompatible), file/amongus-orbs.zip (incompatible), file/lever-indicator.zip (incompatible), indium
    Current Language: en_us
    Locale: en_US
    CPU: 12x AMD Ryzen 5 5600 6-Core Processor

Additional context

Caused by a change in DH, but does not occur without Iris.

markspl commented 4 months ago

Hi, this also happens on Iris 1.21 version (1.7.3+mc1.21)

Minecraft Version

Minecraft 1.21

Iris Version

iris-1.7.3+mc1.21

Sodium Version

Sodium 0.5.11+mc1.21

Operating System

Win 10.0.19045 Build 19045

What is your GPU?

GeForce GTX 1070

Java Version

Java 21.0.3

Error message (from Minecraft Launcher window)

The game crashed whilst unexpected error Error: java.lang.NoSuchFieldError: Class com.seibel.distanthorizons.api.methods.events.abstractEvents.DhApiBeforeBufferRenderEvent$EventParam does not have member field 'com.seibel.distanthorizons.coreapi.util.math.Vec3f modelPos'

ElfenZitronen commented 3 months ago

Context for what caused the issue

James Seibel (GMT-6) — 30/06/2024 19:10 I just added a temporary proof-of-concept beacon renderer to the nightly build. Every time you place a beacon it will make a white beacon beam. More changes to come, but not today.

Also I might've broken some of the MC builds due to accidentally removing some necessary imports. Oh, and I probably also broke Iris since there were some non-API objects that were being used by the API that I had to fix.

Doesn't occur in Distant Horizons 2.1.2-a-dev.

Fheuef commented 3 months ago

Can confirm that the issue is likely linked to Iris-DH compatibility (though it seems to come from the latest DH version), the crash only happens with a DH compatible shader enabled

ajaxburger commented 3 weeks ago

Updating as launching 1.21.1 breaks this as well. Iris 1.7.4 does not exist. Removed existing Shaders / Conflicts and it is still broken on DH 2.2.1-a

Incompatible mods found! net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other! A potential solution has been determined, this may resolve your problem:

  • Remove mod 'Iris' (iris) 1.7.3+mc1.21 (C:\Users\XXXXX\AppData\Roaming.minecraft\mods\iris-1.7.3+mc1.21.jar). More details:
  • Mod 'Distant Horizons' (distanthorizons) 2.2.1-a is incompatible with version 1.7.4 or earlier of mod 'Iris' (iris), but a matching version is present: 1.7.3+mc1.21! at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:51) at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:196) at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:146) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)