IrisShaders / Iris

A modern shaders mod for Minecraft compatible with existing OptiFine shader packs
https://irisshaders.dev
GNU Lesser General Public License v3.0
3.34k stars 632 forks source link

Some leaf types become invisible and/or look strange after a certain distance from the player when running without Sodium #411

Open isuewo opened 3 years ago

isuewo commented 3 years ago

Steps to reproduce: 1) use the latest commit of Iris 1.17 with no other mods installed 2) set mipmapping to at least 2 3) high fov & high render distance (110 and 24 in this screenshot) to make the bug more visible 4) don't use shaders, otherwise it won't appear 5) look at birch/spruce/acacia and probably other leaves that are far away

Log: latest.log

F3 Screenshot: 2021-06-20_16 32 11

satriamjati commented 3 years ago

110 and 24 works fine for me

x60id commented 3 years ago

Unfinished rendering but enough to notice distance. 2021-06-21_04 34 11 latest.log It seems alright using Iris Standalone 1.17.

coderbot16 commented 3 years ago

This almost certainly has to do with mipmapping, and I'm like 90% sure what causes it.

isuewo commented 3 years ago

Yes, I tested it again with different mipmapping levels and setting it to off or 1 seems to fix the problem.

AViewFromTheTop commented 2 years ago

This now happens in the latest developmental 1.18 version of Iris that was put under Releases, where Iris and Sodium are separated. The versions where Sodium was bundled with Iris didn't have this issue, and I believe that manually building an earlier version of 1.18 Iris without Sodium also didn't have this issue. Mipmapping does indeed seem to have an effect on it as I tried setting it to both Off and One like the previous comment mentioned, so at least it doesn't seem to be a new issue. Edit: Forgot to mention, this only happens with Birch, Acacia, and Spruce leaves.

Track07-cda commented 2 years ago

It might relate to the graphic driver settings. I have the same issue when running on the NVIDIA graphic card, but no such issue when using integrated Intel graphics. (Test on 1.18 with developmental version of iris)

coderbot16 commented 2 years ago

The development versions had this bug resurface for a bit, but now it is only observable without Sodium installed, which is now only possible when running in a development environment.

coderbot16 commented 2 years ago

The fix for this bug (only currently observable in a dev env) would likely be to add a core shader override that fixed up the alpha test as needed for our bettermipmaps patches.