Peer Review

[shainatrevino]

Hi @Irisfee and @xiy1992

First off, amazing job on this project! It is clear that you both are very knowledgeable about manipulating various forms of data in R. I was very impressed! That being said, a lot of your code was above my skill level in R, so it was a little difficult for me to critically evaluate parts of your code that was very complex. I did not make any changes to your actual code, but just added in a few minor comments and noted an error message I got when trying to run the plot codes.

The strengths that I noticed:

• Your final project dashboard looks great! it is a very simple layout with only the need to know information (I am assuming, since I don't know what your project is). I really like the layouts of the plots and the design choices you made regarding the theme.
• Your functions are written very clearly! Although I don't really know what is going on in the whole project, your functions are written in a way that I can see exactly what is going on and what the purpose is - great job!
• I also thought the way that you used map in your script was a major strength. It took me a little bit to understand what was going on, but I think it is a really innovative way to use map for reading in data that I hadn't really thought too much about before.

Things I learned from your script:

• I did not know that there was a package called ggpubr that is used with ggplot for additional themes, I will have to check this out because I really liked the theme elements of your plot.
• I had never seen sprintf before so I looked it up. Therefore, I learned that you can use sprintf instead of c() for a character vector that can refer to both text and variable values at the same time.

Areas for improvement:

• I would consider putting in more comments throughout the code. It was hard for me to understand what exactly was going on (outside of the functions you wrote). However, if the code is just to produce the dashboard, this may be unnecessary.
• Relatedly, and specifically if the point is an informative dashboard, I would consider adding in a sidebar that explains the dataset and question you are seeking to answer as well as explains a little about the layout of the table. Then in the plot, I would add a caption explaining the acronyms for the facet titles, and a note underneath with the take home message or result.

Let me know if you have any questions about this.

Best, Shaina

@datalorax

[Irisfee]

Hi @shainatrevino ,

Thanks for reviewing our codes and thanks for all your suggestions!

The problem you mentioned about the afex and emmeans also happened while others running the codes, and it seems that installing the emmeans again and re-library it solve the problem (We don't know why since we didn't get this error).

we agree we definitely need more comments and explanations! sorry for the confusions while reading our not-well-commented codes.

Best, Xi & Yufei

[datalorax]

Thanks Shaina! Really nice review. As a bit of a clarifier, sprintf uses "C-style" string operations. It's a little complex but basically ends up working a lot like glue::glue instead of paste. See here for an okay, but not great, explanation: https://www.r-bloggers.com/paste-paste0-and-sprintf/

I like the suggestion to add in a sidebar. Explaining acronyms is also definitely important.