Amazing work @Irisfee and @xiy1992! This is seriously impressive. Here are some thoughts:
Areas of strength:
Your data wrangling skills are amazing. You have also very clearly thought through how to make the most of functional programming to make your code as concise and readable as possible—I especially appreciate that you considered alternative options for the bit of code when you’re labeling categories. Sometimes we just have to accept when the best code possible is still quite verbose! I also really love the final graph and think it looks really clean and colorblind-friendly.
Something I learned:
I liked seeing an example of how to wrap C code (e.g. sprintf) into R—thanks for showing me how!
Areas for improvement:
This is super impressive work, so I really don’t have much to say here. I noticed one instance where you avoid copying and pasting—i.e. you could use dplyr::mutate_at when you are converting variables to integers (roughly around line 165)
Also, I would maybe suggest just adding some explanatory text in your dashboard to give more context for what the data is about and how to interpret the graph and table. Of course, that has nothing to do with functional programming, but it would be a nice way to round out the finished product.
datalorax
commented
5 years ago
Amazing work @Irisfee and @xiy1992! This is seriously impressive. Here are some thoughts:
Areas of strength: Your data wrangling skills are amazing. You have also very clearly thought through how to make the most of functional programming to make your code as concise and readable as possible—I especially appreciate that you considered alternative options for the bit of code when you’re labeling categories. Sometimes we just have to accept when the best code possible is still quite verbose! I also really love the final graph and think it looks really clean and colorblind-friendly.
Something I learned: I liked seeing an example of how to wrap C code (e.g. sprintf) into R—thanks for showing me how!
Areas for improvement: This is super impressive work, so I really don’t have much to say here. I noticed one instance where you avoid copying and pasting—i.e. you could use dplyr::mutate_at when you are converting variables to integers (roughly around line 165)
Also, I would maybe suggest just adding some explanatory text in your dashboard to give more context for what the data is about and how to interpret the graph and table. Of course, that has nothing to do with functional programming, but it would be a nice way to round out the finished product.
@datalorax