search

Irma-Response / irma-api

Irma Needs API, a fork of Harvey Needs
https://irma-api.herokuapp.com
GNU General Public License v3.0
9 stars 8 forks source link

Clarify Pets fields -- checkbox vs text field in output #27

Closed wslack closed 7 years ago

wslack commented 7 years ago

Right now, if "Pets" is unchecked for a shelter, the main site says "Pets Allowed? Unknown" Users putting in data may not realize that they need to do something else besides "leave box unchecked" when they know shelters aren't taking pets.

We should make the data a three-way selection - yes, no, and unknown.

rogerroelofs commented 7 years ago

How valuable is 'unknown' ? Setting the db field to false when the box is not checked is easy enough. Shelter data entry needs should dictate UI. 3 radios vs. select vs. the checkbox we have now.

tabinfl commented 7 years ago

Beyond complicating coding, this is where we should reach out to the shelter and clarify the unknown. Don't want evacuees going on a wild goose chase for shelter.

tabinfl commented 7 years ago

Handled in https://github.com/Irma-Response/irma-api/pull/28

wslack commented 7 years ago

That's fine - as long as "unchecked" doesn't cause "unknown" to be published.

rogerroelofs commented 7 years ago

It doesn't. Unknown was showing for pets being blank, not for the pets allowed checkbox. After the deploy the map will show 'Yes' or 'No' with the text from the pets fields appended.