Irma-Response / irma-api

Irma Needs API, a fork of Harvey Needs
https://irma-api.herokuapp.com
GNU General Public License v3.0
9 stars 8 forks source link

Add filters to propagate list of specific shelters by... #41

Open techieimposter opened 7 years ago

techieimposter commented 7 years ago

Filter #1: Name of Data Entry Volunteer who has edited/updated shelters. Search by name capability. Filter #2: Keywords located in Private Notes and Notes field. Search by keyword.

rogerroelofs commented 7 years ago

You mean on https://irma-api.herokuapp.com/shelters ? Isn't updated_by the name of the data entry volunteer?

techieimposter commented 7 years ago

The column is there. No names listed.

ryanbrainard commented 7 years ago

I'm going to try taking a stab at this. First issue I'm working on on this repo, so will need to get acquainted with the codebase.

ryanbrainard commented 7 years ago

I just got the app setup locally and the updated_at column is working there, so it seems like a problem with the data in the prod database, not the app itself. I'm going to leave that task to someone who has prod access, and switch focus to the searching of notes.

EDIT: re-read the comment above. i can still try adding search capability on both columns, but will ignore the fact that updated_at is empty on prod.

techieimposter commented 7 years ago

That's great. I appreciate it. Goal of these requests: speed up accessing relevant shelters/narrowing down focus to the shelters I need to focus on.

ryanbrainard commented 7 years ago

@sullisphere Pushed up the fix https://github.com/Irma-Response/irma-api/pull/43